Psd/develop#23
Merged
Merged
Conversation
…tc_20191210 ufs_public_release: update from DTC (fix compiler warnings)
Ufs public release
Ufs public release
…ber of OpenMP threads provided from the calling model
release/public-v1: partial fix to threading issue
update documentation
update develop with master
Release/public v1
climbfuji
reviewed
May 13, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me. As per yesterday's discussion, will approve for merging when tested in full with a ufs-weather-model commit on all platforms (since this is going to the authoritative branch used by the UFS models).
lisa-bengtsson
approved these changes
May 13, 2020
Collaborator
lisa-bengtsson
left a comment
lisa-bengtsson
left a comment
There was a problem hiding this comment.
This looks good to me.
climbfuji
approved these changes
May 21, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I am approving this before my two days of vacation, so that it can be merged once the regression tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for pulling in the threading fix and documentation from the release/public-v1 branch.
All regression tests pass on hera.