Feature/add daily bfg harvester surface energy balance #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
energy balance.
values returned by the harvester daily_bfg.py. The test is for the derived variable netR. netR is derived from the variables dswrf_ave,dlwrf_ave,ulwrf_ave,uswrf_ave,shtfl_ave,lhtfl_ave which are located in the bfg control netcdf files. The values for weighted mean,min,max and variance of each of the variables are calculated in a separate python script and hard coded in the file.
The netR is the name given to the surface energy balance. The netR is derived from the following variables: dswrf_ave,dlwrf_ave,ulwrf_ave,uswrf_ave,shtfl_ave,lhtfl_ave located in the bfg control Netcdf files in the test data directory. The statistics weighted_mean,minimum,maximum and variance of each of the required variables are calculated in the pyton script. The weighted_mean of netR is also calculated. The statistics are calculated using the python class located in src/score_hv stats_utils.py.
amschne
requested changes
Feb 15, 2024
There was a problem hiding this comment.
This is a good start to the SEB harvester, which will be very helpful to diagnose surface fluxes in replay and upcoming reanalysis data sets.
It seems that this PR is dependent on #48 for stat_utils, which is not part of this PR. I suggest we work on that first before trying to test and develop this PR.
A couple issues, however, to address now:
- the init.py files have been removed and I'm not sure why. I think at least one is needed so that score_hv can be imported as a module
- there are extraneous files in test/data that should be removed from this PR
and variance of the required variables that are needed to calculate the derived field surface energy balance.
to line 216. Uncommented the field prateb_ave.
|
the _init.py file is gone. pytests passed |
|
Per team discussion: this will be separated into a new PR using new bfg and stat utils framework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the calculation of the surface_energy_balance(netR). The harvester that
calculates the netR is daily_bfg.py. The netR is a derived variable using
the required variables dswrf_ave,dlwrf_ave,ulwrf_ave,uswrf_ave,shtfl_ave,lhtfl_ave. These variables are:
dswrf_ave : averaged surface downward shortwave flux
dlwrf_ave : surface downward longwave flux
ulwrf_ave : surface upward longwave flux
uswrf_ave : averaged surface upward shortwave flux
shtfl_ave : surface sensible heat flux
lhtfl_ave : surface latent heat flux
The netR calculation is the weighted mean of these variables as follows:
netR = dswrf_ave + dlwrf_ave - ulwrf_ave - uswrf_ave - shtfl_ave - lhtfl_av.
The test script for the daily_bfg.py harvester is test_harvester_surface_energy_balance.py. In the
test_harvester_surface_energy_balance.py script the values returned from the harvester daily_bfg.py are
compared to values calculated in a separate python script. The values calculated in the separate python script
are hard coded in to the test script.
The files used in the test are the bfg control netcdf files with the names:bfg_1994mmdd${00,06,09}_fhr${00,06,09)_surf_energy_balance_control.nc.
pytest passed for the test of the harvester.