Port the workflow to ursa#46
Conversation
ClaraDraper-NOAA
left a comment
There was a problem hiding this comment.
@zhichang-guo Thanks for doing this, it looks good. Please see comments for requested changes.
Two questions:
- Is there an update to the ufs-land-driver hash that should be included in this PR?
- It looks like we're still using hr3 static file and forcing, and the 2023 orog files. Is this what is being used for GEFS? For the develop workflow, I'd like to update these both to the latest version (we can then revert for GEFS if need be). @barlage For awareness.
|
Can you please then update the hash for the model submodule to what it should be then? (instead of cloning the desired branch in the build script). |
|
@zhichang-guo Would you be able to push your updates for this today? I'd like to get it merged as soon as we can. |
I removed build_landDA.sh, updated ufs-land-driver to Mike's ursa_configure branch. Mike's ccpp-physics branch has not been merged to ufs-community, so I added his ccpp-physics repo as a romote, and updated his branch glacier_mods. Then, I failed to push my updates (error messages say "failed to push some refs"). I do not know how to fix the problem. Also, if we set the machine-specific orog path, how can we broadcast them to the namelists which are to be used by the fortran programs (sed won't work, I think). So I have difficulties to get it done soon. The directory is located in /scratch3/NCEPDEV/stmp/Zhichang.Guo/land-offline_workflow/ @ClaraDraper-NOAA |
tsga
left a comment
There was a problem hiding this comment.
@zhichang-guo @ClaraDraper-NOAA It seems you have agreed to exclude/delete the "build_landDA.sh" file from this PR?
If that is the case, the only comments left are
- the absolute paths to files that I suggest we keep for now
- Clara's comments about changes in the readme. @zhichang-guo can you address those and mark them resolved?
Then we can merge this and start the tests as you pointed out in the email yesterday.
I removed the script build_landDA.sh and mode corresponding changes to the README. Thanks. @tsga |
|
thank you @zhichang-guo |
Nice work, thanks! @tsga |
Merging these changes. Will address the ufs-land-driver changes in separate PR next. Add an issue for machine specific modules and files paths, to be addressed later.
PR Instructions:
Notes on preparing PR, using git can be found in README_git
Describe your changes
Summarise all code changes included in PR:
List any associated PRs in the submodules.
N/A
Issue ticket number and link
List the git Issue that this PR addresses:
#45
Test output
Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Does it pass the DA_IMS_test?
Yes, it passes the test
If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
No exchanges to the test results
Checklist before requesting a review