Skip to content

Port the workflow to ursa#46

Merged
tsga merged 7 commits into
NOAA-PSL:developfrom
zhichang-guo:feature/port_ursa
Sep 25, 2025
Merged

Port the workflow to ursa#46
tsga merged 7 commits into
NOAA-PSL:developfrom
zhichang-guo:feature/port_ursa

Conversation

@zhichang-guo
Copy link
Copy Markdown
Collaborator

@zhichang-guo zhichang-guo commented Sep 23, 2025

PR Instructions:

  1. Provide details under all headings below.
  2. Assign Clara and one other person as reviewers.
  3. If the PR is not ready for merging, add the "DRAFT/DO NOT MERGE" label.
  4. When a PR is ready to merge, remove the "DRAFT/DO NOT MERGE" and email Clara.
  5. Before requesting that the PR be merged, complete the checklist below.

Notes on preparing PR, using git can be found in README_git

Describe your changes

Summarise all code changes included in PR:

  1. Updated the static files, ERA5 forcing data location and file names, changed the input variable name for precipitation;
  2. Fixed some glitches which may lead to a failure of the scripts;
  3. Added flexibility for selection of resolutions in the namelists for ufs-land-driver and vector2tile;
  4. Coded a shell script "build_landDA.sh", which can build all for the workflow;
  5. Added some notes for building the workflow and running the land DA experiments;

List any associated PRs in the submodules.
N/A

Issue ticket number and link

List the git Issue that this PR addresses:
#45

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?

Does it pass the DA_IMS_test?
Yes, it passes the test
If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
No exchanges to the test results

Checklist before requesting a review

  • My branch being merged is up to date with the latest develop.
  • I have performed a self-review of my code by examining the differences that will be merged.
  • I have not made any unnecessary code changes / changed any default behavior.
  • My code passes the DA_IMS_test.

@zhichang-guo zhichang-guo changed the title ort ursa Port the workflow to ursa Sep 23, 2025
Copy link
Copy Markdown
Collaborator

@ClaraDraper-NOAA ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhichang-guo Thanks for doing this, it looks good. Please see comments for requested changes.

Two questions:

  1. Is there an update to the ufs-land-driver hash that should be included in this PR?
  2. It looks like we're still using hr3 static file and forcing, and the 2023 orog files. Is this what is being used for GEFS? For the develop workflow, I'd like to update these both to the latest version (we can then revert for GEFS if need be). @barlage For awareness.

Comment thread do_submit_test.sh Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread build_landDA.sh Outdated
Comment thread build_landDA.sh Outdated
Comment thread build_landDA.sh Outdated
Comment thread settings_cycle_test Outdated
Comment thread template.tile2vector
Comment thread template.ufs-noahMP.namelist.era5
Comment thread template.vector2tile
@zhichang-guo
Copy link
Copy Markdown
Collaborator Author

@zhichang-guo Thanks for doing this, it looks good. Please see comments for requested changes.

Two questions:

  1. Is there an update to the ufs-land-driver hash that should be included in this PR?
  2. It looks like we're still using hr3 static file and forcing, and the 2023 orog files. Is this what is being used for GEFS? For the develop workflow, I'd like to update these both to the latest version (we can then revert for GEFS if need be). @barlage For awareness.
  1. Yes. To my knowledge Mike's PR Glacier modifications in NoahMP to address GFSv17 biases ufs-community/ccpp-physics#316 has been approved but not merged and the branch ursa_configure of Mike's ufs-land-driver has not been merged yet.
  2. We checked. No update has been done to 20231027 version of orog files (identical to version 20240917). We did not bother doing this update. @ClaraDraper-NOAA @barlage

@ClaraDraper-NOAA
Copy link
Copy Markdown
Collaborator

@zhichang-guo Thanks for doing this, it looks good. Please see comments for requested changes.
Two questions:

  1. Is there an update to the ufs-land-driver hash that should be included in this PR?
  2. It looks like we're still using hr3 static file and forcing, and the 2023 orog files. Is this what is being used for GEFS? For the develop workflow, I'd like to update these both to the latest version (we can then revert for GEFS if need be). @barlage For awareness.
  1. Yes. To my knowledge Mike's PR Glacier modifications in NoahMP to address GFSv17 biases ufs-community/ccpp-physics#316 has been approved but not merged and the branch ursa_configure of Mike's ufs-land-driver has not been merged yet.
  2. We checked. No update has been done to 20231027 version of orog files (identical to version 20240917). We did not bother doing this update. @ClaraDraper-NOAA @barlage

Can you please then update the hash for the model submodule to what it should be then? (instead of cloning the desired branch in the build script).

@ClaraDraper-NOAA
Copy link
Copy Markdown
Collaborator

@zhichang-guo Would you be able to push your updates for this today? I'd like to get it merged as soon as we can.

@zhichang-guo
Copy link
Copy Markdown
Collaborator Author

zhichang-guo commented Sep 24, 2025

@zhichang-guo Would you be able to push your updates for this today? I'd like to get it merged as soon as we can.

I removed build_landDA.sh, updated ufs-land-driver to Mike's ursa_configure branch. Mike's ccpp-physics branch has not been merged to ufs-community, so I added his ccpp-physics repo as a romote, and updated his branch glacier_mods. Then, I failed to push my updates (error messages say "failed to push some refs"). I do not know how to fix the problem. Also, if we set the machine-specific orog path, how can we broadcast them to the namelists which are to be used by the fortran programs (sed won't work, I think). So I have difficulties to get it done soon. The directory is located in /scratch3/NCEPDEV/stmp/Zhichang.Guo/land-offline_workflow/ @ClaraDraper-NOAA

Copy link
Copy Markdown
Collaborator

@tsga tsga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhichang-guo @ClaraDraper-NOAA It seems you have agreed to exclude/delete the "build_landDA.sh" file from this PR?
If that is the case, the only comments left are

  • the absolute paths to files that I suggest we keep for now
  • Clara's comments about changes in the readme. @zhichang-guo can you address those and mark them resolved?

Then we can merge this and start the tests as you pointed out in the email yesterday.

@zhichang-guo
Copy link
Copy Markdown
Collaborator Author

@zhichang-guo @ClaraDraper-NOAA It seems you have agreed to exclude/delete the "build_landDA.sh" file from this PR? If that is the case, the only comments left are

  • the absolute paths to files that I suggest we keep for now
  • Clara's comments about changes in the readme. @zhichang-guo can you address those and mark them resolved?

Then we can merge this and start the tests as you pointed out in the email yesterday.

I removed the script build_landDA.sh and mode corresponding changes to the README. Thanks. @tsga

@tsga
Copy link
Copy Markdown
Collaborator

tsga commented Sep 25, 2025

thank you @zhichang-guo

@tsga tsga merged commit 36dcdc0 into NOAA-PSL:develop Sep 25, 2025
@zhichang-guo
Copy link
Copy Markdown
Collaborator Author

thank you @zhichang-guo

Nice work, thanks! @tsga

tsga added a commit to tsga/land-offline_workflow that referenced this pull request Mar 3, 2026
Merging these changes. Will address the ufs-land-driver changes in separate PR next. Add an issue for machine specific modules and files paths, to be addressed later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants