Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] WIP: Reload BLE benchmark data #1155

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

RobHanna-NOAA
Copy link
Contributor

@RobHanna-NOAA RobHanna-NOAA commented May 10, 2024

Download and process the latest BLE benchmark data.

Changes

  • data/ble/ble_benchmark:

    • create_ble_benchmark.py: Added logging system, added GDAL config to control output messages, add system to cleanup temp working files.
    • create_flow_forecast_file.py: Add logging system.
    • preprocess_benchmark.py: Adjust GDAL to control excess output.
  • src/utils:

    • shared_validators.py: Add function to valid if huc is good.

Testing

Lots of small scale testing, plus a full download of all valid HUC ble benchmark data.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@RobHanna-NOAA RobHanna-NOAA changed the title Dev reload ble bench WIP - Dev reload ble bench May 10, 2024
@RobHanna-NOAA RobHanna-NOAA self-assigned this May 10, 2024
@RobHanna-NOAA RobHanna-NOAA added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 10, 2024
@RobHanna-NOAA RobHanna-NOAA linked an issue May 10, 2024 that may be closed by this pull request
@RobHanna-NOAA RobHanna-NOAA changed the title WIP - Dev reload ble bench [1pt] PR: Reload BLE benchmark data May 13, 2024
@RobHanna-NOAA RobHanna-NOAA marked this pull request as ready for review May 13, 2024 23:31
@RobHanna-NOAA RobHanna-NOAA changed the title [1pt] PR: Reload BLE benchmark data [1pt] WIP: Reload BLE benchmark data Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[21pt] Reload all BLE benchmark data
1 participant