Skip to content

Physics changes made for/during HFIP 2020#37

Merged
DomHeinzeller merged 2 commits into
NOAA-GSL:gsd/developfrom
climbfuji:HFIP_GFchanges
Aug 14, 2020
Merged

Physics changes made for/during HFIP 2020#37
DomHeinzeller merged 2 commits into
NOAA-GSL:gsd/developfrom
climbfuji:HFIP_GFchanges

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Aug 14, 2020 •
edited
Loading

Update submodule pointer for ccpp-physics to support PR NOAA-GSL/ccpp-physics#50.

Associated PRs:
NOAA-GSL/ccpp-physics#50
NOAA-GSL/fv3atm#45
#37

For regression testing information, see below.

@climbfuji climbfuji mentioned this pull request Aug 14, 2020
Merged
@DomHeinzeller DomHeinzeller mentioned this pull request Aug 14, 2020
Merged
@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Aug 14, 2020

Regression testing on hera.intel against official baseline using rt.conf: the following tests failed as expected, all others pass:

fv3_ccpp_gsd_diag3d_debug 053 failed in check_result
fv3_ccpp_gsd_diag3d_debug 053 failed in run_test
fv3_ccpp_gsd_debug 052 failed in check_result
fv3_ccpp_gsd_debug 052 failed in run_test
fv3_ccpp_rap 039 failed in check_result
fv3_ccpp_rap 039 failed in run_test
fv3_ccpp_gsd 038 failed in check_result
fv3_ccpp_gsd 038 failed in run_test

rt_hera_intel.log
rt_hera_intel_fail_test.log

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Aug 14, 2020

Regression testing on hera.gnu against official baseline using rt_gnu.conf: the following test fails as expected, all others pass:

fv3_ccpp_gsd 007 failed in check_result
fv3_ccpp_gsd 007 failed in run_test

rt_hera_gnu.log
rt_hera_gnu_fail_test.log

@DomHeinzeller DomHeinzeller self-requested a review August 14, 2020 00:27
@DomHeinzeller DomHeinzeller merged commit eff83ae into NOAA-GSL:gsd/develop Aug 14, 2020
@DomHeinzeller
Copy link
Copy Markdown

DomHeinzeller commented Aug 14, 2020

Regression testing on hera.intel using rt_ccpp_gsd.conf: first create new baseline, then verify against it: all tests pass.

rt_ccpp_gsd_hera_intel_create.log
rt_ccpp_gsd_hera_intel_verify.log

christinaholtNOAA pushed a commit that referenced this pull request Mar 2, 2023
@DusanJovic-NOAA @BrianCurtis-NOAA @jkbk2004
Create ESMF field attributes using the same kind as field data values (…
863ffdd 
…ufs-community#1566)

* adding regional control back to jenkins-ci (#37)

* Create ESMF field attributes using the same kind as field data values

Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DomHeinzeller DomHeinzeller DomHeinzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@climbfuji @DomHeinzeller