Ugwp v1#34
Closed
mdtoy wants to merge 2 commits into
Closed
Conversation
…-model into ugwp_v1 Updating my local branch with latest gsd/develop commits.
climbfuji
reviewed
Jul 23, 2020
| fi | ||
|
|
||
| mkdir -p ${STMP}/${USER} | ||
| # mkdir -p ${STMP}/${USER} |
There was a problem hiding this comment.
These changes will need to be reverted. and a new regression test will be required - maybe also remove an existing test, depending on how you handle the phasing out of cires_ugwp_v0.
|
This PR will be replaced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dom,
Here is the draft pull request (3 of 3) for helping out with my UGWP_v1 CCPP conversion.
Thank you,
Mike