rrfs_cloud: Adding NSSL Physics.#41
Merged
christinaholtNOAA merged 5 commits intoJun 15, 2021
Merged
Conversation
christinaholtNOAA
requested review from
christopherwharrop-noaa and
danielabdi-noaa
and removed request for
JeffBeck-NOAA
danielabdi-noaa
approved these changes
Jun 13, 2021
christopherwharrop-noaa
approved these changes
Jun 14, 2021
Ruifang-Li
pushed a commit
to Ruifang-Li/ufs-srweather-app
that referenced
this pull request
Sep 23, 2021
## DESCRIPTION OF CHANGES: Remove the script link_fix.sh from the build system since the fix directories this script creates under ufs-srweather-app are not needed [the ones that are needed (in NCO mode) are under regional_workflow, not under ufs-srweather-app]. ## TESTS CONDUCTED: On Orion, built successfully without link_fix.sh. ## CONTRIBUTORS (optional): @JeffBeck-NOAA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Add NSSL physics to the list of physics packages to build by default. The modifications to Externals.cfg should be removed once those PRs have been merged -- they're only here for easier testing purposes ATM.
TESTS CONDUCTED:
Built and run on Hera and AWS. Currently testing for unexpected answer changes compared to what was run during the HWT.
Dependencies