[uwtools_integration] Integrate sfc climo#267
Merged
nbharwani-cu merged 19 commits intoSep 24, 2024
Merged
Conversation
added 10 commits
August 26, 2024 19:00
nbharwani-cu
commented
Sep 19, 2024
nbharwani-cu
commented
Sep 19, 2024
Collaborator
christinaholtNOAA
left a comment
There was a problem hiding this comment.
This is shaping up very nicely. Looking forward to the reorg of the run script.
nbharwani-cu
commented
Sep 20, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
nbharwani-cu
commented
Sep 23, 2024
Collaborator
christinaholtNOAA
left a comment
There was a problem hiding this comment.
Thanks for doing my cleanup! I appreciate that.
This is shaping up really nicely. I left some additional comments and will finish with a full review when the functions refactor in the run script is complete.
christinaholtNOAA
approved these changes
Sep 23, 2024
Collaborator
christinaholtNOAA
left a comment
There was a problem hiding this comment.
I think this looks great! Just one more suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
N/A
DOCUMENTATION:
N/A
CHECKLIST