Skip to content

[uwtools_integration] Integrate sfc climo#267

Merged
nbharwani-cu merged 19 commits into
NOAA-GSL:uwtools_integrationfrom
nbharwani-cu:integrate_sfc_climo
Sep 24, 2024
Merged

[uwtools_integration] Integrate sfc climo#267
nbharwani-cu merged 19 commits into
NOAA-GSL:uwtools_integrationfrom
nbharwani-cu:integrate_sfc_climo

Conversation

@nbharwani-cu
Copy link
Copy Markdown

@nbharwani-cu nbharwani-cu commented Sep 19, 2024

DESCRIPTION OF CHANGES:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • derecho.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

N/A

DOCUMENTATION:

N/A

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Comment thread scripts/make_sfc_climo.py
Comment thread scripts/make_sfc_climo.py Outdated
Copy link
Copy Markdown
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up very nicely. Looking forward to the reorg of the run script.

Comment thread ush/config_defaults.yaml Outdated
Comment thread ush/config_defaults.yaml Outdated
Comment thread ush/config_defaults.yaml Outdated
Comment thread parm/wflow/prep.yaml Outdated
@nbharwani-cu nbharwani-cu requested a review from WeirAE September 20, 2024 15:02
Comment thread scripts/make_sfc_climo.py Outdated
@nbharwani-cu nbharwani-cu self-assigned this Sep 23, 2024
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_orog.py
Comment thread scripts/exregional_make_orog.sh
Comment thread scripts/make_sfc_climo.py Outdated
@nbharwani-cu nbharwani-cu marked this pull request as ready for review September 23, 2024 16:24
Copy link
Copy Markdown
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing my cleanup! I appreciate that.

This is shaping up really nicely. I left some additional comments and will finish with a full review when the functions refactor in the run script is complete.

Comment thread parm/wflow/prep.yaml
Comment thread scripts/make_orog.py
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread scripts/make_sfc_climo.py Outdated
Comment thread ush/config_defaults.yaml
Copy link
Copy Markdown
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Just one more suggestion.

Comment thread scripts/make_sfc_climo.py
Copy link
Copy Markdown

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nbharwani-cu nbharwani-cu merged commit 029a029 into NOAA-GSL:uwtools_integration Sep 24, 2024
@nbharwani-cu nbharwani-cu deleted the integrate_sfc_climo branch September 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants