Skip to content

Merge #248 again because code manager merged too soon#249

Merged
SamuelTrahanNOAA merged 5 commits into
NOAA-GSL:feature/RRFS_dev1from
SamuelTrahanNOAA:fewer-ifi-fields
Sep 18, 2023
Merged

Merge #248 again because code manager merged too soon#249
SamuelTrahanNOAA merged 5 commits into
NOAA-GSL:feature/RRFS_dev1from
SamuelTrahanNOAA:fewer-ifi-fields

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown

@SamuelTrahanNOAA SamuelTrahanNOAA commented Sep 18, 2023

A code manager merged my PR #248 before I had finished making the requested changes. Someone needs to merge the branch a second time. Otherwise, RRFS_dev1 will recursively clone itself until it hits quota.

These changes are identical to #248 except that I'm not updating the UPP hash.

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title Merge again because code manager merged too soon Merge #248 again because code manager merged too soon Sep 18, 2023
@SamuelTrahanNOAA
Copy link
Copy Markdown
Author

Could someone please verify the changes are as they expect and post a comment to that effect?

@SamuelTrahanNOAA
Copy link
Copy Markdown
Author

Ming told me by email that everything looks right, and asked me too merge this PR.

I merged your last PR and approved this one. Please go ahead and merge it.

So, I'll press the button now.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit d35f682 into NOAA-GSL:feature/RRFS_dev1 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants