Fix anavinfo not to use vertical velocity for CRTM#595
Closed
shoyokota wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@shoyokota Can you submit this PR to the https://github.com/NOAA-EMC/rrfs-workflow? The regional_workflow should be frozen at this time. |
Author
|
@guoqing-noaa Thank you for letting me know. I will create this PR in https://github.com/NOAA-EMC/rrfs-workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR is to prevent SDL/VDL failure (NaN is sometimes detected in the 2nd outer loop) in GSI. This failure is caused by adding w (vertical velocity) to one of the variables for calculating radiance, so crtm_use for w in anavinfo is changed from 2 to -1.
TESTS CONDUCTED:
I checked this fix doesn't change the analysis and prevents NaN in several reruns as we expected.
DEPENDENCIES:
DOCUMENTATION:
ISSUE (optional):
This bug is introduced in #451