fix anavinfo.rrfs_conv_dbz to assimilate radar reflectivity in hybrid-EnVar#535
Merged
chunhuazhou merged 1 commit intoJun 14, 2023
Conversation
shoyokota
requested review from
CurtisAlexander-NOAA,
JacobCarley-NOAA,
JeffBeck-NOAA,
JiliDong-NOAA,
MatthewPyle-NOAA,
ShunLiu-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
chunhuazhou,
daviddowellNOAA,
guoqing-noaa,
hu5970 and
terraladwig
as code owners
chunhuazhou
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR fixes the improper setting of control vectors in anavinfo.rrfs_conv_dbz. According to the GSI code, "motley" variables should be set at the end in this file. In addition, "as/tsfc_sdv" should be zero for control variables added for dbz DA (w,qr,qs,qi,qg,ql,dbz) not to set default static B of these variables in current RRFS.
TESTS CONDUCTED:
I checked that EnVar using current anavinfo.rrfs_conv_dbz failed in the case of 200 MPI processes and that the fixed one could obtain the reasonable analysis.
DEPENDENCIES:
DOCUMENTATION:
TBD
ISSUE (optional):
This bug is introduced in #451 and became obvious after #533