Add gefs interp to the workflow#494
Merged
chunhuazhou merged 3 commits intoMar 22, 2023
Merged
Conversation
chunhuazhou
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
daviddowellNOAA,
guoqing-noaa,
hu5970 and
terraladwig
as code owners
chunhuazhou
force-pushed
the
Add_GEFS_Interp
branch
2 times, most recently
from
8d617ff to
7379d2d
Compare
chunhuazhou
force-pushed
the
Add_GEFS_Interp
branch
from
7379d2d to
4054060
Compare
|
Could you sync with the latest feature/RRFS_dev1 to include sub-hour forecast changes? Thanks, |
Collaborator
Author
|
@hu5970 Have you tested this on WCOSS2 yet? Is there any change needed? Thanks! |
hu5970
reviewed
Mar 22, 2023
| <!ENTITY MAKE_SFC_CLIMO_TN "{{ make_sfc_climo_tn }}"> | ||
| <!ENTITY GET_EXTRN_ICS_TN "{{ get_extrn_ics_tn }}"> | ||
| <!ENTITY GET_EXTRN_LBCS_TN "{{ get_extrn_lbcs_tn }}"> | ||
| <!ENTITY GET_GEFS_LBCS_TN "get_gefs_lbcs"> |
There was a problem hiding this comment.
Can you define this one like {{ get_extrn_lbcs_tn }}?
chunhuazhou
force-pushed
the
Add_GEFS_Interp
branch
from
0e0c325 to
ace5b0c
Compare
hu5970
approved these changes
Mar 22, 2023
hu5970
left a comment
hu5970
left a comment
There was a problem hiding this comment.
Looks good. Tested on Jet with retro case and there are no problem found.
hongli-wang
pushed a commit
to hongli-wang/regional_workflow
that referenced
this pull request
Jun 14, 2023
* Add GEFS data copying and time interpolation to the workflow * Change the default EnKF localization length to 300km for the conventional obs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Incorporate the previously stand-alone GEFS time interpolation task into the regional workflow, to replace the regular task get_extrn_lbcs, when EXTRN_MDL_NAME_LBCS="GEFS" and LBC_SPEC_INTVL_HRS="1". This new task will copy/link the GEFS files as done by the regular task get_extrn_lbcs and then do time interpolation for the missing hourly GEFS data based on the existing 3-hourly GEFS data.
TESTS CONDUCTED:
Successfully tested on Jet.
DEPENDENCIES:
DOCUMENTATION:
ISSUE (optional):
CONTRIBUTORS (optional):
If others have contributed to this work aside from the PR author, list them here