Add PM2.5 DA for RRFS-SD by hongli-wang · Pull Request #448 · NOAA-GSL/regional_workflow

hongli-wang · 2022-11-14T22:38:14Z

No description provided.

guoqing-noaa

Suggest to merge the following pairs:

gsiparm.anl.sh               gsiparm.anl_sd.sh
exregional_run_analysis.sh   exregional_run_analysis_sd.sh 
JREGIONAL_RUN_ANA            JREGIONAL_RUN_ANAL_SD

guoqing-noaa · 2022-11-17T17:03:53Z

+   netcdf_diag=.true.,binary_diag=.false.,
+   l_obsprvdiag=${l_obsprvdiag},
+ /     
+   netcdf_diag=${netcdf_diag},binary_diag=${binary_diag},


Line 24 should be inside the &SETUP block

Line 24 will be removed.

guoqing-noaa · 2022-11-17T17:04:14Z

+   hzscl=${bkgerr_hzscl},
+   bw=0.,fstat=.true.,
+/
+   usenewgfsberror=${usenewgfsberror},


Line 34 should be inside the &BKGERR block

Line 34 will be removed.

guoqing-noaa · 2022-11-17T17:06:48Z

+   fv3sar_bg_opt=${fv3lam_bg_type},
+ /
+   l_hyb_ens=${ifhyb},
+   uv_hyb_ens=.true.,


Line 59-63: remove line 62, replace line 59 with line 63

The lines will be removed.

guoqing-noaa · 2022-11-17T17:07:46Z

@@ -0,0 +1,92 @@
+gsi_namelist="


I would suggest to combine gsiparm.anl_sd.sh into gsiparm.anl.sh

This is doable. PM2.5 DA is just a 3DVar run with a static B generated for aerosol DA. The current design only need one parameter DO_SDDACYCLE to switch among tasks. Othwise more parameters will be needed to pass to the merged scripts.

hongli-wang · 2022-11-17T18:25:56Z

Suggest to merge the following pairs:

gsiparm.anl.sh               gsiparm.anl_sd.sh
exregional_run_analysis.sh   exregional_run_analysis_sd.sh 
JREGIONAL_RUN_ANA            JREGIONAL_RUN_ANAL_SD

I thought about this. The current implementation is the most efficient way to run a separate 3DVAR to produce the smoke and dust traces for RRFS-SD. I have no problem merging them to make the modification fellow the standard of the regional workflow.

hongli-wang · 2022-12-02T18:43:13Z

Suggest to merge the following pairs:

gsiparm.anl.sh               gsiparm.anl_sd.sh
exregional_run_analysis.sh   exregional_run_analysis_sd.sh 
JREGIONAL_RUN_ANA            JREGIONAL_RUN_ANAL_SD

@guoqing-noaa I had merged the files as you suggested and pushed back to my branch. Should I create. a new PR from my latest commit? Thanks.

hongli-wang · 2022-12-02T19:29:09Z

@guoqing-noaa I just merged my commits and forced pushed back to my branch. This PR should work. Thanks.

hongli-wang · 2023-01-17T23:02:39Z

Suggest to merge the following pairs:

gsiparm.anl.sh               gsiparm.anl_sd.sh
exregional_run_analysis.sh   exregional_run_analysis_sd.sh 
JREGIONAL_RUN_ANA            JREGIONAL_RUN_ANAL_SD

Hi Guoqing,

Could you please review this PR since I had revised the scripts after your comments. There were conflicts shown however, I had rebased my code and pushed back today.

Thanks,
Hongli

guoqing-noaa · 2023-01-18T18:23:21Z

   i_gsdqc=2,
 /
 &CHEM
+  laeroana_fv3smoke=.true.,


Do we need to set the default value of laeroana_fv3smoke to .false. so that this will not affect other parts when not doing chem DA?

Suggest to add a variable in config files and then we can write as follows:
laeroana_fv3smoke=${laeroana_fv3smoke}
You could reference line 21, 22 in this file.

netcdf_diag=${netcdf_diag},binary_diag=${binary_diag}, l_obsprvdiag=${l_obsprvdiag},

I can update this. The issue is that the base of GSL GSI is a few months behind my GSI, so the GSL GSI can NOT the two parameters, which has to be deleted as you commented in a next review.

I can add a variable in the config file, but to make the GSL GSI work, the parameters have to be deleted when running a regular meteorological DA.

guoqing-noaa · 2023-01-18T18:28:08Z

+  sed '/berror_fv3_cmaq_regional/d' gsiparm.anl.1 > gsiparm.anl
+  rm -fr gsiparm.anl.sd gsiparm.anl.1
+fi
+


Is it possible to update GSI first and then we don't need this temporary workaround?

This requires GSL GSI is rebased to the latest EMC GSI development branch. If not, we have to delete the parameters related to SMOKE DA to make the meteorological DA run. That is one reason I added a separated *sh to produce gsiparm.anl for SD DA in my previous PR.

Is it possible to update GSL GSI with those two namelist parameters according to the EMC/develop branch? Don't need to add the full functionality at the moment, but only to add placeholders so that GSL GSI be able to proceed with the new namelist.

@guoqing-noaa
I think it would be good I keep the lines in my personal application or add the two parameters in GSL/GSI. I will delete the lines in this PR.

Thanks! GSL/GSI has to be updated with these new namelist parameters any way. If you do it now (even just putting a namelist placeholder), it will save some future work, :)

FYI, I just checked the latest GSL/GSI (the feature/rrfs_dev branch). It already included the following two parameters:

berror_fv3_cmaq_regional laeroana_fv3smoke

@guoqing-noaa
That is great. My current test is based base_e, which doesn't accept the two namelist parameters. I may use the lastest GSL GSI rrfs_dev in my next test.

Sorry that although berror_fv3_cmaq_regional is already there and we also have the laeroana_fv3smoke variable in chemmod.f90, laeroana_fv3smoke is not added in gsimod.f90 yet. I believe it was added only in your own GSI copy at the moment. Could you create a PR to update GSL/GSI with this? (otherwise it will stop the normal RRFS workflow). Thanks!

guoqing-noaa · 2023-01-18T18:59:57Z

-   i_use_2mQ4B=2,
-   i_use_2mT4B=1,
+   i_use_2mQ4B=${ii_use_2mq4b},
+   i_use_2mT4B=${ii_use_2mt4b},


To be consistent, we can use ${i_use_2mQ4B} and ${i_use_2mT4B} in the config file.
Similar to line 160-161:

readin_localization=${readin_localization}, ens_fast_read=${ens_fast_read},

I will change.

guoqing-noaa · 2023-01-18T19:01:45Z

 lread_obs_skip=.false.
 if_model_dbz=.false.
+ii_use_2mq4b=2
+ii_use_2mt4b=1


See a previous comment on this. Also suggest to put them in the config files.

This is default for base_E. I will change.

@guoqing-noaa

Correction: this is analysis type dependent, needs to be here. My GSI doesn't support (2,1) options for the two parameters.

@guoqing-noaa
The two parameters had been defined in config file:
i_use_2mQ4B=0
i_use_2mT4B=0

They need to assign different values for meteorological DA or SD DA, so they are also in this shell script.

guoqing-noaa · 2023-01-18T22:26:31Z

-   i_use_2mQ4B=2,
-   i_use_2mT4B=1,
+   i_use_2mQ4B=${i_use_2mq4b},
+   i_use_2mT4B=${i_use_2mt4b},


${i_use_2mq4b} and ${i_use_2mt4b}
should be ${i_use_2mQ4B} and ${i_use_2mT4B}
They are case-sensitive.

guoqing-noaa · 2023-01-18T22:27:16Z

 lread_obs_skip=.false.
 if_model_dbz=.false.
+i_use_2mQ4B=2
+i_use_2mT4b=1


i_use_2mT4b --> i_use_2mT4B

@guoqing-noaa fixed. thanks.

guoqing-noaa · 2023-01-18T23:39:34Z

+  nummem=0
+  beta1_inv=0.0
+  i_use_2mQ4b=0
+  i_use_2mT4b=0


655 and 656 change to:
i_use_2mQ4B=0
i_use_2mT4B=0

@guoqing-noaa Fixed. Thanks.

guoqing-noaa · 2023-01-19T17:31:05Z

 /
 &CHEM
+  laeroana_fv3smoke=${laeroana_fv3smoke},
+  berror_fv3_cmaq_regional=${berror_fv3_cmaq_regional}.,


Just found that there is an extra dot before the comma (line 203).

hongli-wang requested review from CurtisAlexander-NOAA, JeffBeck-NOAA, TrevorAlcott-NOAA, christinaholtNOAA, chunhuazhou, daviddowellNOAA, guoqing-noaa, hu5970 and terraladwig as code owners November 14, 2022 22:38

guoqing-noaa requested changes Nov 17, 2022

View reviewed changes

hongli-wang force-pushed the feature/RRFS_dev1 branch from 066c1ea to cc8eafb Compare December 2, 2022 19:24

hongli-wang force-pushed the feature/RRFS_dev1 branch from cc8eafb to 9514673 Compare December 20, 2022 18:10

hongli-wang added 4 commits January 17, 2023 17:22

Add PM2.5 DA for RRFS-SD

d64a1c3

Refine for RRFS-SD DA

12b4682

remove unused files for RRFS-SD DA

6d8f158

refine gsiparm.anl.sh

d67dcff

hongli-wang force-pushed the feature/RRFS_dev1 branch from 9514673 to d67dcff Compare January 17, 2023 22:50

hongli-wang requested a review from guoqing-noaa January 17, 2023 22:51

guoqing-noaa reviewed Jan 18, 2023

View reviewed changes

hongli-wang force-pushed the feature/RRFS_dev1 branch 2 times, most recently from 2066cf1 to 64ba50f Compare January 19, 2023 00:04

guoqing-noaa reviewed Jan 19, 2023

View reviewed changes

Comment thread scripts/exregional_run_analysis.sh

hongli-wang force-pushed the feature/RRFS_dev1 branch from 64ba50f to fc14ab5 Compare January 19, 2023 17:24

guoqing-noaa reviewed Jan 19, 2023

View reviewed changes

Refine some paramters

a35b4e3

hongli-wang force-pushed the feature/RRFS_dev1 branch from fc14ab5 to a35b4e3 Compare January 19, 2023 17:49

guoqing-noaa approved these changes Jan 19, 2023

View reviewed changes

guoqing-noaa merged commit 38d4e73 into NOAA-GSL:feature/RRFS_dev1 Jan 19, 2023

MichaelLueken mentioned this pull request Apr 5, 2023

[develop] Add new RRFS variables such as NWGES and workflow control variables ufs-community/ufs-srweather-app#647

Closed

37 tasks

Conversation

hongli-wang commented Nov 14, 2022 • edited by guoqing-noaa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guoqing-noaa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hongli-wang commented Nov 17, 2022

Uh oh!

hongli-wang commented Dec 2, 2022

Uh oh!

hongli-wang commented Dec 2, 2022

Uh oh!

hongli-wang commented Jan 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

hongli-wang commented Nov 14, 2022 •

edited by guoqing-noaa

Loading