Skip to content

make usenewgfsberror configurable; add l_obsprvdiag#369

Merged
guoqing-noaa merged 2 commits into
NOAA-GSL:feature/RRFS_dev1from
guoqing-noaa:prRRFS
May 3, 2022
Merged

make usenewgfsberror configurable; add l_obsprvdiag#369
guoqing-noaa merged 2 commits into
NOAA-GSL:feature/RRFS_dev1from
guoqing-noaa:prRRFS

Conversation

@guoqing-noaa
Copy link
Copy Markdown
Collaborator

@guoqing-noaa guoqing-noaa commented May 3, 2022

No description provided.

hu5970
hu5970 reviewed May 3, 2022
View reviewed changes
Copy link
Copy Markdown

@hu5970 hu5970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anavinfo and GSI run scripts also need to be changed to use old number and file.

BERROR_FN should be defined OK
How about ANAVINFO_FN="anavinfo.fv3lam_hrrr" ?

@hu5970
Copy link
Copy Markdown

hu5970 commented May 3, 2022

@guoqing-noaa :
control_vector::
!var level itracer as/tsfc_sdv an_amp0 source funcof
sf 65 0 0.90 -1.0 state u,v
vp 65 0 0.90 -1.0 state u,v
ps 1 0 1.00 -1.0 state prse
t 65 0 1.40 -1.0 state tv
q 65 1 0.80 -1.0 state q
sst 1 0 1.00 -1.0 state sst
stl 1 0 1.00 -1.0 motley sst
sti 1 0 1.00 -1.0 motley sst

Those as/tsfc_sdv need to be changed back. You need a new anavinfo for 3DRTMA

@guoqing-noaa
Copy link
Copy Markdown
Collaborator Author

guoqing-noaa commented May 3, 2022

Thanks, Ming. I forgot to change anavinfo and run script. I will check this.

@guoqing-noaa
Copy link
Copy Markdown
Collaborator Author

guoqing-noaa commented May 3, 2022

@hu5970 I added anavinfo.rtma.

@guoqing-noaa guoqing-noaa merged commit 2a708fa into NOAA-GSL:feature/RRFS_dev1 May 3, 2022
@guoqing-noaa guoqing-noaa deleted the prRRFS branch May 3, 2022 17:50
robgpita pushed a commit to robgpita/regional_workflow that referenced this pull request Jun 2, 2022
@mkavulich
Update develop branch for generic linux, MacOS capability (NOAA-GSL#539)
09ae4f1 
## DESCRIPTION OF CHANGES: 
This change will add the capability to run regional_workflow (as part of the SRW app) on MacOS and generic LINUX platforms. Most of these changes are identical to those in NOAA-GSL#402 (hash bc08607) but some additional modifications needed to be made due to intervening changes in the develop branch.

## TESTS CONDUCTED: 
Ran Graduate Student Test on new platforms:
 - my personal Mac machine (MacOS Catalina 10.15.7) MacOS with gnu 9.4.0 compilers. 
 - Cheyenne compute node as a faux "stand-alone" machine, intel 19.1.1 compilers

Ran suite of end-to-end tests on Cheyenne (intel/19.1.1) and Hera (intel/18.0.5.274). All passed as expected.

Tests also passed on WCOSS, MacOS Mojave, RedHat Linux.

## ISSUE: 
Will resolve NOAA-GSL#369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@chunhuazhou chunhuazhou Awaiting requested review from chunhuazhou chunhuazhou is a code owner

@CurtisAlexander-NOAA CurtisAlexander-NOAA Awaiting requested review from CurtisAlexander-NOAA CurtisAlexander-NOAA is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA is a code owner

@terraladwig terraladwig Awaiting requested review from terraladwig terraladwig is a code owner

@TrevorAlcott-NOAA TrevorAlcott-NOAA Awaiting requested review from TrevorAlcott-NOAA

1 more reviewer

@hu5970 hu5970 hu5970 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guoqing-noaa @hu5970