Add github actions workflow to test SRWA build#352
Merged
christinaholtNOAA merged 11 commits intoJun 27, 2022
Conversation
robgpita
requested review from
christinaholtNOAA,
christopherwharrop-noaa and
venitahagerty
christinaholtNOAA
requested changes
Apr 30, 2022
Collaborator
christinaholtNOAA
left a comment
christinaholtNOAA
left a comment
There was a problem hiding this comment.
@robgonzalezpita This is nice work. I left some comments/suggestions below.
If corresponding branch is not found in SRWA repository, checkout the base branch. Change how ./build.sh is printed to stdout.
…t github.refs for debugging on web interface
…nd branch name in the SRWA, add final job to display build status in web interface
robgpita
force-pushed
the
feature/CI_build_test
branch
from
84a1c06 to
b22ff0f
Compare
robgpita
added
the
ci-aws-intel-build
robgpita
commented
Jun 17, 2022
Author
robgpita
left a comment
robgpita
left a comment
There was a problem hiding this comment.
I believe I've addressed all of the old requested changes. Please re-review and suggest any new changes.
christinaholtNOAA
requested changes
Jun 24, 2022
| # (Cloning repositories outside of the GITHUB_WORKSPACE directory is not supported with actions/checkout@v3, so it needs to be moved into the parent directory seperately) | ||
| # The SRWA is cloned within the GITHUB_WORKSPACE (default location of where 'run' commands are executed ), we need to move its location up one directory, as the regional_workflow is nested within the SRWA. | ||
| Clone_SRWA: | ||
| name: Clone SRWA and move into parent directory |
Collaborator
There was a problem hiding this comment.
Why does it need to move up one directory? Can you not clone SRW where you want it, and then clone regional_workflow inside that clone using the path option for both?
Author
There was a problem hiding this comment.
@christinaholtNOAA, you pose some great questions, and this a much better approach. I updated the GHA workflow to clone SRW and place the regional_workflow inside of that clone using the path option.
robgpita
added
ci-aws-intel-build
robgpita
added
ci-aws-intel-build
christinaholtNOAA
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Currently, there are no Continuous Integration (C.I.) tests for this repository. C.I. tests are considered a software engineering best practice, with numerous benefits to developers as well as the code-base. This PR adds the first step in implementing a C.I. pipeline (building the ufs-srweather-app). Forthcoming work will add another GitHub Actions workflow file which will automate the running of Workflow End To End tests.
TESTS CONDUCTED:
A build test accomplished via the GHA workflow file was done on an AWS Parallel cluster configured as a self-hosted runner with all of the necessary dependencies, including
hpc-stackwith versions matched as closely as possible to srw_common (different patch of g2). As versions of dependent libraries change, the self-hosted runner will need to be updated, reflecting those changes.A successful GitHub actions workflow run has been accomplished, on my fork. Once a GitHub Actions Self-Hosted runner is configured and assigned to the NOAA-GSL fork, the proposed GitHub Actions Workflow will run on it.
DEPENDENCIES:
This GitHub Action Workflow is run on a self-hosted runner, which must be assigned to this repository. A machine configured as a Github Actions self-hosted runner is necessary to run this workflow.
PR #152 for the ufs-srweather-app is a concurrent pull request. While not a dependency, once that one has been accepted, the workflow can be simplified in utilizing those changes.
DOCUMENTATION:
PR #152 in the
ufs-srweather-appincludes adocs/UsersGuide/source/ContinuousIntegration.rstfile.CONTRIBUTORS:
@christinaholtNOAA @christopherwharrop-noaa @venitahagerty