Skip to content

add SST_ROOT and NA-3km configure file#278

Merged
hu5970 merged 8 commits into
NOAA-GSL:feature/RRFS_dev1from
ShunLiu-NOAA:RRFS_dev1_p0
Feb 28, 2022
Merged

add SST_ROOT and NA-3km configure file#278
hu5970 merged 8 commits into
NOAA-GSL:feature/RRFS_dev1from
ShunLiu-NOAA:RRFS_dev1_p0

Conversation

@ShunLiu-NOAA
Copy link
Copy Markdown
Collaborator

@ShunLiu-NOAA ShunLiu-NOAA commented Feb 16, 2022

ISSUE :
Fixes issue mentioned in [#]ShunLiu-NOAA#64 and ShunLiu-NOAA#70. SST_ROOT on WCOSS is added. Also, the configure file for NA-3km on WCOSS is combined with config.sh.RRFS_NA_3km as suggested by @guoqing-noaa.

@guoqing-noaa
Copy link
Copy Markdown
Collaborator

guoqing-noaa commented Feb 17, 2022

@ShunLiu-NOAA Is it possible to merge config.sh.RRFS_NA_3km_wcoss into config.sh.RRFS_NA_3km? We can have a section at the end of config.sh.RRFS_NA_3km to config WCOSS-specific settings and also let the script automatically determine whether current platform is WCOSS.

The RTMA group already use a similar strategy for config.sh.RTMA_NA_3km:
https://github.com/NOAA-GSL/regional_workflow/blob/3DRTMA/ush/config.sh.RTMA_NA_3km

@ShunLiu-NOAA
Copy link
Copy Markdown
Collaborator Author

@guoqing-noaa You suggestion is well taken. I combined config.sh.RRFS_NA_3km_wcoss to config.sh.RRFS_NA_3km. config.sh.RRFS_NA_3km_wcoss is deleted.
Thanks.

@hu5970 hu5970 merged commit f09005c into NOAA-GSL:feature/RRFS_dev1 Feb 28, 2022
guoqing-noaa pushed a commit to guoqing-noaa/regional_workflow that referenced this pull request Sep 15, 2024
Co-authored-by: benjamin blake <benjamin.blake@clogin03.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants