Add FVCOM into NA 3km real time runs.#269
Merged
Merged
Conversation
hu5970
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
chunhuazhou,
guoqing-noaa,
jaymes-kenyon and
terraladwig
as code owners
| fi | ||
| done | ||
| # latest_fvcom_file=$(ls -t ${FVCOM_DIR} | head -n1) | ||
| # fvcom_data_fp="${FVCOM_DIR}/${latest_fvcom_file}" |
Collaborator
There was a problem hiding this comment.
Line 709 and line 710 were commented out. Is it safe to remove them?
Author
There was a problem hiding this comment.
Yes, it is safe to remove those lines as we have better way to find the FVCOM data.
| FVCOM_DIR = \"${FVCOM_DIR}\" | ||
| FVCOM_FILE= \"${FVCOM_FILE}\" " | ||
|
|
||
| else |
Collaborator
There was a problem hiding this comment.
Line 719: else is not needed as we expect print_err_msg_exit to stop this script if fvcom_data_fp does not exist.
This may help the code appearance as we don't need to indent further.
Author
There was a problem hiding this comment.
OK, we should change print_err_msg_exit to print_info_msg.
| #Format for fvcom_time: YYYY-MM-DDTHH:00:00.000000 | ||
| fvcom_time="${YYYY}-${MM}-${DD}T${HH}:00:00.000000" | ||
| # fvcom_time="${DATE_FIRST_CYCL:0:4}-${DATE_FIRST_CYCL:4:2}-${DATE_FIRST_CYCL:6:2}T${CYCL_HRS[0]}:00:00.000000" | ||
| # |
Collaborator
There was a problem hiding this comment.
can we safely remove comments line 724 and 725?
guoqing-noaa
approved these changes
Jan 31, 2022
guoqing-noaa
pushed a commit
to guoqing-noaa/regional_workflow
that referenced
this pull request
Sep 15, 2024
…oducts (NOAA-GSL#269) * Create postxconfig files for f00 and f01 to remove unnecessary grib2 records * Remove additional accumulation and 1-h averaged fields from f00 files * Update RTMA config files --------- Co-authored-by: benjamin blake <benjamin.blake@clogin09.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com> Co-authored-by: benjamin blake <benjamin.blake@clogin03.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: benjamin blake <benjamin.blake@clogin05.cactus.wcoss2.ncep.noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the regional workflow to make FVCOM can be used by NA3km real-time runs.
This function has been used in NA 3km realtime run.
The FVCOM code in UFS_UTIL also needs to be updated. Working on an PR to update the FVCOM code also.