RRFS_dev1: dix cycle time for make_ics#264
Merged
Merged
Conversation
hu5970
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
chunhuazhou,
guoqing-noaa,
jaymes-kenyon and
terraladwig
as code owners
christinaholtNOAA
approved these changes
Jan 13, 2022
Collaborator
christinaholtNOAA
left a comment
christinaholtNOAA
left a comment
There was a problem hiding this comment.
LGTM!
I did learn recently that if EXTRN_MDL_ICS_OFFSET_HRS is set to an empty string, this logic fails and data adds a single hour to the base time. Is there any way that EXTRN_MDL_ICS_OFFSET_HRS is ever empty?
Author
|
The default value for EXTRN_MDL_ICS_OFFSET_HRS is 0. If someone set it to empty value, I guess the script will crash. |
guoqing-noaa
pushed a commit
to guoqing-noaa/regional_workflow
that referenced
this pull request
Sep 15, 2024
…AA-GSL#264) * Update UFS_UTILS for RRFSFW, remove unneeded modules from run.ver * Use ufs_utils_1_12_2 tag * Remove w3nco from build.ver as it is deprecated --------- Co-authored-by: benjamin blake <benjamin.blake@clogin08.cactus.wcoss2.ncep.noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to consider EXTRN_MDL_ICS_OFFSET_HRS when calculates cycle hour for make_ics.