Changes to exregional_run_post.sh required to run new EMC UPP#249
Merged
EricJames-NOAA merged 2 commits intoNov 8, 2021
Merged
Conversation
… changes involve new namelist syntax in itag file.
EricJames-NOAA
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
chunhuazhou,
guoqing-noaa,
hu5970,
jaymes-kenyon and
terraladwig
as code owners
chunhuazhou
reviewed
Nov 8, 2021
Collaborator
chunhuazhou
left a comment
chunhuazhou
left a comment
There was a problem hiding this comment.
Do we have the right version of UPP code for this script change?
Author
|
@chunhuazhou yes I have an approved PR under EMC_POST for this new UPP code. Have not merged it yet but I can do that now... |
guoqing-noaa
reviewed
Nov 8, 2021
| MODELNAME='${POST_FULL_MODEL_NAME}' | ||
| fileNameFlux='${phy_file}' | ||
| fileNameFlat='postxconfig-NT.txt' | ||
| / |
Collaborator
There was a problem hiding this comment.
It would be good if the content (i.e. Line 192-198) inside the "model_inputs" namelist is indented.
Author
There was a problem hiding this comment.
Thanks Guoqing. I made that change...I'm assuming it won't change how the lines are read in?
guoqing-noaa
approved these changes
Nov 8, 2021
|
Eric,
Please make sure the UPP code (ufs-srweather-app hash for UPP) matches
these regional workflow changes.
Thanks,
Ming
…On Mon, Nov 8, 2021 at 1:51 PM EricJames-NOAA ***@***.***> wrote:
Merged #249 <#249> into
feature/RRFS_dev1.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#249 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVV23RSUKJL2L5X5BKXNHLULAZ3LANCNFSM5HTFQXOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Author
|
Ming, Thanks for the reminder. I just opened a PR to update Externals.cfg with the latest consistent updates for UPP and regional_workflow. Eric |
guoqing-noaa
pushed a commit
to guoqing-noaa/regional_workflow
that referenced
this pull request
Sep 15, 2024
* Fix small bugs in v0.8.3 test: 1) update UPP control and NT file 2) Use TPP_RUN_ANALYSIS in exrrfs_run_analysis.sh * Update model hash to point to release branch. * Update the GSI hash to the current version. * Update rrfs_utl hash to include Donnie's fix for blending. --------- Co-authored-by: ming hu <ming.hu@dlogin02.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: ming hu <ming.hu@dlogin09.dogwood.wcoss2.ncep.noaa.gov> Co-authored-by: ming hu <ming.hu@dlogin05.dogwood.wcoss2.ncep.noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Script changes involve new namelist syntax in itag file. This is related to a NOAA_EMC/UPP PR by Ka Yee Wong a couple of weeks ago.
NOTE: This script change should be deployed at the same time as the new NOAA-EMC UPP code (see EMC_post PR).
TESTS CONDUCTED:
Changes were tested in retrospective mode for RRFS_NA_3km on Jet.