Changes for initializing ensemble from GDASENKF netcdf files on HERA#248
Merged
Merged
Conversation
chunhuazhou
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
guoqing-noaa,
hu5970,
jaymes-kenyon and
terraladwig
as code owners
guoqing-noaa
reviewed
Nov 5, 2021
|
|
||
| if [ "${MACHINE}" = "JET" ] || [ "${MACHINE}" = "HERA" ] || [ "${MACHINE}" = "ORION" ]; then | ||
| fns_on_disk=( "${yy}${ddd}${hh}0${fcst_mn}0${fcst_hh}" ) | ||
| elif [ "${MACHINE}" = "HERA" ] ; then |
Collaborator
There was a problem hiding this comment.
remove [ "${MACHINE}" = "HERA" ] from line 399
Collaborator
Author
There was a problem hiding this comment.
The data path and filename of FV3GFS are different from what we have on Jet. That is why I made these changes. Has anybody tested with FV3GFS real-time data on HERA with the old setting?
Collaborator
There was a problem hiding this comment.
You added [ "${MACHINE}" = "HERA" ] in Line 401 but did not remove it from line 399, so Line 401 will not execute.
Collaborator
Author
There was a problem hiding this comment.
Done with the change. Thank you!
| fcst_hhh=( $( printf "%03d " "${lbc_spec_fhrs[@]}" ) ) | ||
|
|
||
| if [ "${MACHINE}" = "JET" ] || [ "${MACHINE}" = "HERA" ] || [ "${MACHINE}" = "ORION" ]; then | ||
| # if [ "${MACHINE}" = "JET" ] || [ "${MACHINE}" = "HERA" ] || [ "${MACHINE}" = "ORION" ]; then |
guoqing-noaa
approved these changes
Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Changes for initializing ensemble from GDASENKF NetCDF files on HERA.
TESTS CONDUCTED:
Retro tests done on HERA.
ISSUE (optional):
CONTRIBUTORS (optional):
If others have contributed to this work aside from the PR author, list them here