RRFS_ens: Adopting the changes from Guoqing to have the option "upgrade" for pre-existing directories#116
Merged
Conversation
…eexisting directories (PR # 111 from feature/RRFS_dev1)
chunhuazhou
requested review from
CurtisAlexander-NOAA,
JeffBeck-NOAA,
TrevorAlcott-NOAA,
christinaholtNOAA,
hu5970,
jaymes-kenyon and
terraladwig
as code owners
guoqing-noaa
approved these changes
May 19, 2021
Collaborator
guoqing-noaa
left a comment
guoqing-noaa
left a comment
There was a problem hiding this comment.
Looks good to me. Only one minor cosmetic comment and I hope it can be addressed before the final merge.
| while [ -d "${old_dir_or_file}" ]; do | ||
| i=$[$i+1] | ||
| old_indx=$( printf "%03d" "$i" ) | ||
| old_dir_or_file="${dir_or_file}/old${old_indx}" |
Collaborator
There was a problem hiding this comment.
better to indent line 138 to align with line 139,140
EdwardColon-NOAA
pushed a commit
to EdwardColon-NOAA/regional_workflow
that referenced
this pull request
Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Adopting the changes from Guoqing to have the option "upgrade" for pre-existing directories (See #111 from feature/RRFS_dev1)
TESTS CONDUCTED:
ISSUE (optional):
CONTRIBUTORS (optional):
@guoqing-noaa