Skip to content

Feature/rrfs dev1: add retro and radar tten functions #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hu5970 merged 8 commits into from
May 18, 2021
Merged

Feature/rrfs dev1: add retro and radar tten functions #108

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
00521b1
Add 3-km CONUS and AK configure files for dev2
hu5970 May 14, 2021
8bae7f7
Feature/rrfs dev2: add configure files (#106)
May 14, 2021
b4d0d0e
Add functions to run retro with staged data on disk.
hu5970 May 17, 2021
adc6703
Merge remote-tracking branch 'upstream/feature/RRFS_dev2' into HEAD
hu5970 May 17, 2021
1b99c70
Update based on review.
hu5970 May 18, 2021
8138ddb
Bug fix for using GFS on JET for 3km NA.
hu5970 May 18, 2021
5de8919
Use string for FH_DFI_RADAR.
hu5970 May 18, 2021
3a85143
Update explanation for FH_DFI_RADAR.
hu5970 May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/exregional_make_ics.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,10 @@ case "${EXTRN_MDL_NAME_ICS}" in
fn_grib2="${EXTRN_MDL_FNS[0]}"
input_type="grib2"
convert_nst=False
fn_atm_nemsio="${EXTRN_MDL_FNS[0]}"
fn_sfc_nemsio="${EXTRN_MDL_FNS[1]}"
if [ "$MACHINE" == "WCOSS_DELL_P3" ]; then
fn_atm_nemsio="${EXTRN_MDL_FNS[0]}"
fn_sfc_nemsio="${EXTRN_MDL_FNS[1]}"
fi
fi
vgtyp_from_climo=True
sotyp_from_climo=True
Expand Down
12 changes: 12 additions & 0 deletions ush/config.sh.RRFS_dev1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ FIX_GSI=/mnt/lfs4/BMC/nrtrr/RRFS/fix/fix_gsi
FIX_CRTM=/home/rtrr/FIX_EXEC_MODULE/crtm/CRTM_v2.3.0
OBSPATH_NSSLMOSIAC=/public/data/radar/nssl/mrms/conus
RADARREFL_TIMELEVEL=(0 15 30 45)
#FH_DFI_RADAR=(0.0,0.25,0.5)

@christinaholtNOAA christinaholtNOAA May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this setting be on? If not, please remove commented code.

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some will be on and some will be off. It will be used in 3km CONUS if the parallel test in the next couple of week show positive impact.

@guoqing-noaa guoqing-noaa May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean FH_DFI_RADAR=(0.0 0.25 0.5) instead of FH_DFI_RADAR=(0.0,0.25,0.5) (the latter is a one element array, i.e. "0.0,0.25,0.5" ) ?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to include comma as it will be used to fill in namelist variable.

@guoqing-noaa guoqing-noaa May 18, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see. In this case, to avoid confusion, would it be enough to just let FH_DFI_RADAR="0.0,0.25,0.5" and hence no need to deal with an array which contains only one item?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't not work when python generates the namelist for FV3.


VERBOSE="TRUE"

Expand Down Expand Up @@ -53,6 +54,17 @@ CYCLEMONTH="5-7"
#CYCLEDAY="1-4"

if [[ $DO_RETRO == "true" ]] ; then

if [[ $MACHINE == "jet" ]] ; then
EXTRN_MDL_SOURCE_BASEDIR_ICS=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/hrrr/conus/wrfnat/grib2

@guoqing-noaa guoqing-noaa May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have data staging scripts available? Or most users will get retro data from /mnt/lfs4/BMC/wrfruc/Ruifang.Li/data?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we only needs one copy of the data in the disk and all retros should use this one copy of the data to save the disk space.

EXTRN_MDL_SOURCE_BASEDIR_LBCS=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/rap/full/wrfnat/grib2
# EXTRN_MDL_SOURCE_BASEDIR_LBCS=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/gfs/0p25deg/grib2
OBSPATH=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/obs_rap
OBSPATH_NSSLMOSIAC=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/reflectivity
LIGHTNING_ROOT=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/lightning/vaisala/netcdf/
ENKF_FCST=/mnt/lfs4/BMC/wrfruc/Ruifang.Li/data/enkf/atm
fi

@christinaholtNOAA christinaholtNOAA May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove user-specific paths.

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the location we stage the retro data now. Will be used by all other users to run the same retro.


if [[ $LBCS_ICS_ONLY == "true" ]]; then
PREEXISTING_DIR_METHOD="rename"
INITIAL_CYCLEDEF="00 10,22 ${CYCLEDAY} ${CYCLEMONTH} 2021 *"
Expand Down
10 changes: 8 additions & 2 deletions ush/config_defaults.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,9 @@ NOMADS_file_type="nemsio"
#-----------------------------------------------------------------------
#
USE_USER_STAGED_EXTRN_FILES="FALSE"
EXTRN_MDL_SOURCE_BASEDIR_ICS="/base/dir/containing/user/staged/extrn/mdl/files/for/ICs"
EXTRN_MDL_SOURCE_BASEDIR_ICS=""
EXTRN_MDL_FILES_ICS=( "ICS_file1" "ICS_file2" "..." )
EXTRN_MDL_SOURCE_BASEDIR_LBCS="/base/dir/containing/user/staged/extrn/mdl/files/for/LBCs"
EXTRN_MDL_SOURCE_BASEDIR_LBCS=""
EXTRN_MDL_FILES_LBCS=( "LBCS_file1" "LBCS_file2" "..." )
#
#-----------------------------------------------------------------------
Expand Down Expand Up @@ -1009,6 +1009,11 @@ ESGgrid_WIDE_HALO_WIDTH=""
# BLOCKSIZE:
# The amount of data that is passed into the cache at a time.
#
# FH_DFI_RADAR:
# The forecast period of using radar tten. Array of 5:
# (0.0,0.25,0.5,0.75,1.0) to use radar tten in the first hour of the
# forecast with reading new observed tten every 15 minutes.

@guoqing-noaa guoqing-noaa May 18, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change the comments here to something as follows to adapt to the change of FH_DFI_RADAR to a string

# FH_DFI_RADAR:
# the forecast hour to use radar tten, this is used  to set the fh_dfi_radar parameter in input.nml*
# e.g. FH_DFI_RADAR="0.0,0.25,0.5,0.75,1.0" will set fh_dfi_radar = 0.0,0.25,0.5,0.75,1.0 in input.nml* and
# it tells the model to read and apply radar tten at the 0, 15, 30, 45, 60 minutes of forecasts respectively.
#

#

@christinaholtNOAA christinaholtNOAA May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does the period start and end? Is this 0-4 if FH_DFI_RADAR=4? Should it be an array? If so, how many entries, and what do they correspond to?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more details.

# Here, we set these parameters to null strings. This is so that, for
# any one of these parameters:
#
Expand All @@ -1033,6 +1038,7 @@ DT_ATMOS=""
LAYOUT_X=""
LAYOUT_Y=""
BLOCKSIZE=""
FH_DFI_RADAR=(-20000000000)

@guoqing-noaa guoqing-noaa May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to leave FH_DFI_RADAR as an empty array if expected to run without radar tten?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot set empty value to namelist parameters. This is default value for this namelist variable.

@guoqing-noaa guoqing-noaa May 18, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest changing to FH_DFI_RADAR="-20000000000" so as to match another suggested change FH_DFI_RADAR="0.0,0.25,0.5"

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work that way.

#
#-----------------------------------------------------------------------
#
Expand Down
5 changes: 4 additions & 1 deletion ush/generate_FV3LAM_wflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,10 @@ if [ "${DO_DACYCLE}" = "true" ]; then
'nggps_ic' : false,
'mountain' : true,
'warm_start' : true,
}"
}
'gfs_physics_nml': {
'fh_dfi_radar': [${FH_DFI_RADAR[@]}],

@guoqing-noaa guoqing-noaa May 18, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hu5970 To accommodate changing FH_DFI_RADAR to a string, line 845 will need to be updated as:

-    'fh_dfi_radar': [${FH_DFI_RADAR[@]}],
+    'fh_dfi_radar': [${FH_DFI_RADAR}],

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String works now and it is better solution. I have committed the changes. Thanks.

}"

$USHDIR/set_namelist.py -q \
-n ${FV3_NML_FP} \
Expand Down
13 changes: 13 additions & 0 deletions ush/set_extrn_mdl_params.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ else
esac

fi
#
# for retro, the external boundary could come from other location.
#
if [[ "${DO_RETRO}" == "true" && ! -z "${EXTRN_MDL_SOURCE_BASEDIR_ICS}" ]]; then
EXTRN_MDL_SYSBASEDIR_ICS="${EXTRN_MDL_SOURCE_BASEDIR_ICS}"
fi

#
# If EXTRN_MDL_SYSBASEDIR_ICS has not been set (not even to a null string),
# print out an error message and exit.
Expand Down Expand Up @@ -299,6 +306,12 @@ else
esac

fi


if [[ "${DO_RETRO}" == "true" && ! -z "${EXTRN_MDL_SOURCE_BASEDIR_LBCS}" ]]; then
EXTRN_MDL_SYSBASEDIR_LBCS="${EXTRN_MDL_SOURCE_BASEDIR_LBCS}"
fi

#
# If EXTRN_MDL_SYSBASEDIR_LBCS has not been set (not even to a null string),
# print out an error message and exit.
Expand Down
1 change: 1 addition & 0 deletions ush/templates/FV3.input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ FV3_GSD_SAR:

FV3_HRRR:
fv_core_nml:
dz_min: 6.0

@christinaholtNOAA christinaholtNOAA May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an intended change for tten?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bug fix from Tanya.

hord_dp: -5
hord_mt: 5
hord_tm: 5
Expand Down
5 changes: 4 additions & 1 deletion ush/templates/FV3LAM_wflow.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,7 @@ MODULES_RUN_TASK_FP script.

</metatask>

{%- if not do_retro %}
<!--
************************************************************************
************************************************************************
Expand Down Expand Up @@ -993,6 +994,8 @@ MODULES_RUN_TASK_FP script.
</metatask>

{%- endif %}
{%- endif %}

{%- if not do_retro %}
<!--
************************************************************************
Expand All @@ -1013,7 +1016,6 @@ MODULES_RUN_TASK_FP script.

</task>

{%- endif %}
{%- if machine in ["JET", "HERA"] %}

@guoqing-noaa guoqing-noaa May 17, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general question, do retros need the archive task?

@hu5970 hu5970 May 18, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. But I never archived my retros runs and it is OK so far. If we need to archive retro for paper, we should only archive grib2 files under com.

<!--
************************************************************************
Expand All @@ -1035,5 +1037,6 @@ MODULES_RUN_TASK_FP script.
</task>

{%- endif %}
{%- endif %}

</workflow>