Update realtime branch, gsl_ufs_rt #75
Merged
Merged
Conversation
Collaborator
kayeekayee
commented
Mar 6, 2025
kayeekayee
commented
- Ran 120 hours on Hera: /scratch2/BMC/gsd-fv3-dev/KaYee.Wong/global/2025FebMerge/test/rt_merge_dev_Mar05
- Verified output with existing real time results.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| #KYWexport FORECAST_HOUR jobid | ||
| export jobid="${job}.$$" | ||
| fhr3_base="10#${FHR3}" |
Check notice
Code scanning / ShellCheck
Possible misspelling: FHR3 may not be assigned. Did you mean fhr3?
| # GFS restart interval in hours | ||
| #JKHexport restart_interval_gfs=12 | ||
| #KYWexport restart_interval_gfs=-1 ## JKH | ||
| export restart_interval_gfs=$FHMAX_GFS |
Check notice
Code scanning / ShellCheck
Prefer putting braces around variable references even when not strictly required.
| # shellcheck disable=SC2153 | ||
| export FHMAX=${FHMAX_GFS} | ||
| # Convert comma-separated string into bash array | ||
| IFS=', ' read -ra segments <<< "${FCST_SEGMENTS}" |
Check warning
Code scanning / ShellCheck
segments appears unused. Verify use (or export if used externally).
| IFS=', ' read -ra segments <<< "${FCST_SEGMENTS}" | ||
| # Determine MIN and MAX based on the forecast segment | ||
| export FHMIN=$FHMIN_GFS | ||
| export FHMAX=$FHMAX_GFS |
Check notice
Code scanning / ShellCheck
Possible misspelling: FHMAX_GFS may not be assigned. Did you mean FHMAX_HF?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.