RRFS_dev: set convert_dry_rho from false to true.#91
Merged
Conversation
jderrico-noaa
pushed a commit
that referenced
this pull request
Feb 16, 2024
…#681) * Changes to logging and initialization of the CLM Lake Model. 1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model. * merge ccpp-physics #91 (UFS-SRW v3.0.0 SciDoc updates)
zhanglikate
referenced
this pull request
in zhanglikate/ufsatm
Oct 7, 2025
…ng PR#1863) (#1844) * Changes to logging and initialization of the CLM Lake Model. * merge ccpp-physics NOAA-EMC#91 (UFS-SRW v3.0.0 SciDoc updates) 1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model. * explicitly turn of frac_ice for flake * t_grnd(i) should be t_grnd(c) ------------------------------------------------------------------- Co-authored-by: Samuel Trahan <samuel.trahan@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set convert_dry_rho from false to true based on Tanya's suggestion.