Updates to MYNN-EDMF, part II - goes with PR for ccpp-physics#121
Merged
SamuelTrahanNOAA merged 5 commits intoFeb 15, 2022
Conversation
11 tasks
hannahcbarnes
approved these changes
Feb 15, 2022
SamuelTrahanNOAA
approved these changes
Feb 15, 2022
Collaborator
Author
|
Thanks Sam and Shan
…On Tue, Feb 15, 2022 at 2:13 PM Samuel Trahan (NOAA contractor) < ***@***.***> wrote:
Merged #121 <#121> into
gsl/develop.
—
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLRR3W3EDQZZFZXCWDS5VLU3K6XBANCNFSM5NK3MG4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Joseph Olson
Model Physics Branch Chief
Environmental Prediction Advancement Division
NOAA-Global Systems Laboratory
Boulder, Colorado
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the MYNN-EDMF PR (part I):
Testing
How were these changes tested? In short retros & case studies in debug mode
What compilers / HPCs was it tested with? ifort
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
This needs to go with the other MYNN PR:
NOAA-GSL/ccpp-physics#121