Skip to content

dtend: add drag_suite tendencies and fix many bugs in convection tendencies#92

Merged
SamuelTrahanNOAA merged 3 commits into
NOAA-GSL:gsl/developfrom
SamuelTrahanNOAA:bugfix/dtend-man-bugs
May 28, 2021
Merged

dtend: add drag_suite tendencies and fix many bugs in convection tendencies#92
SamuelTrahanNOAA merged 3 commits into
NOAA-GSL:gsl/developfrom
SamuelTrahanNOAA:bugfix/dtend-man-bugs

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented May 25, 2021

Fix many bugs in 3D diagnostic tendency code, found by Man Zhang and Sam Trahan.

ufs-weather-model changes: NOAA-GSL/ufs-weather-model#82
fv3atm changes: NOAA-GSL/fv3atm#92

1. Store rtg (AKA clw AKA qtr) instead of gq0 in DCNV and SCNV
pre/post for schemes that use convective transport. Tracers handled
solely by convective transport (ones not in rtg) are reported as
convective transport tendencies. Tendencies for variables in rtg are
reported as dcnv and scnv tendencies.

2. Report TKE tendencies from gfs v16 PBL.

3. Add diagnostic tendencies to drag_suite
@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

SamuelTrahanNOAA commented May 25, 2021

I just noticed I left some debug prints and commented-out code in the PR. I'll remove it shortly, after recompiling and doing some quick tests.

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

I just noticed I left some debug prints and commented-out code in the PR. I'll remove it shortly, after recompiling and doing some quick tests.

This has been corrected. Also, the error was in fv3atm, not ccpp-physics.

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

Man Zhang is doing an independent test of these changes. They should not be merged until her analysis is complete.

Copy link
Copy Markdown

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes. It's getting more complicated and less portable every time, but that's what we have to live with until the CCPP schemes and framework are tidied up.

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

Thanks for making these changes. It's getting more complicated and less portable every time, but that's what we have to live with until the CCPP schemes and framework are tidied up.

Until the CCPP schemes advertise their tendencies, I have no choice but to duplicate logic several places in the code. There just isn't any other way to get the correct tendencies.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 9346bb7 into NOAA-GSL:gsl/develop May 28, 2021
zhanglikate referenced this pull request in zhanglikate/ccpp-physics Mar 1, 2024
Changes to Logging and Initialization of the CLM Lake Model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants