Mods to MYNN sfc and PBL for fractional/coupled by benwgreen · Pull Request #40 · NOAA-GSL/ccpp-physics

benwgreen · 2020-06-18T21:40:41Z

MYNN surface layer needs very slight changes if it will ever be used to compute surface heat/moisture fluxes (currently done by sfc_nst, sfc_ocean, sfc_sice, sfc_drv_ruc) in the fractional framework.
MYNN boundary layer needs an updated way to compute fluxes for the ocean in the case of fractional mask (this change follows the procedure done in GFS_PBL_generic.F90).
Testing finds these changes make no difference in the case of non-fractional mask and atmosphere-only, so regression test GSD_v0 should pass.
@joeolson42 is in favor of these changes.
Refer to Issue 39 (#39)

Suggested reviewers: @joeolson42 and @shansun6

update 6/10/2020

… into gsd/develop

DomHeinzeller

Thanks! Looks good to me. I'll be testing this after #38 and #36 are merged.

DomHeinzeller · 2020-06-25T14:05:32Z

This PR has been pulled into #41 and will be merged as part of it.

ShanSunNOAA

Could you modify similar line in GFS_PBL_generic.F90
if (fice(i) > one - epsln) then ! no open water, use results from CICE
epsln is not used and can be removed. Thanks!

climbfuji · 2020-06-25T15:26:15Z

Could you modify similar line in GFS_PBL_generic.F90
if (fice(i) > one - epsln) then ! no open water, use results from CICE
epsln is not used and can be removed. Thanks!

This will impact the s2s runs when we merge this to the authoritative repositories. Is this what we want?

ShanSunNOAA · 2020-06-25T15:35:48Z

Yes, practically it is the same, but using if (.not. wet(i)) would be more consistent with the rest of the routine. Thanks, -Shan

…

On Thu, Jun 25, 2020 at 9:26 AM Dom Heinzeller ***@***.***> wrote: Could you modify similar line in GFS_PBL_generic.F90 if (fice(i) > one - epsln) then ! no open water, use results from CICE epsln is not used and can be removed. Thanks! This will impact the s2s runs when we merge this to the authoritative repositories. Is this what we want? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALORMVRSH7OC774MXTOCRMDRYNUCNANCNFSM4OCFQGIQ> .

DomHeinzeller · 2020-06-25T15:56:08Z

Could you modify similar line in GFS_PBL_generic.F90
if (fice(i) > one - epsln) then ! no open water, use results from CICE
epsln is not used and can be removed. Thanks!

This will impact the s2s runs when we merge this to the authoritative repositories. Is this what we want?

Shan, I can't find this line in GFS_PBL_generic.F90. That file in gsd/develop has:

!  --- ...  coupling insertion

      if (cplflx) then
        do i=1,im
          if (oceanfrac(i) > zero) then ! Ocean only, NO LAKES
            if ( .not. wet(i)) then ! no open water
              if (flag_cice(i)) then !use results from CICE
                dusfci_cpl(i) = dusfc_cice(i)
                dvsfci_cpl(i) = dvsfc_cice(i)
                dtsfci_cpl(i) = dtsfc_cice(i)
                dqsfci_cpl(i) = dqsfc_cice(i)
              else !use PBL fluxes when CICE fluxes is unavailable
                dusfci_cpl(i) = dusfc1(i)
                dvsfci_cpl(i) = dvsfc1(i)
                dtsfci_cpl(i) = dtsfc1(i)
                dqsfci_cpl(i) = dqsfc1(i)
              end if
            elseif (icy(i) .or. dry(i)) then ! use stress_ocean from sfc_diff for opw component at mixed point
              tem1 = max(q1(i), 1.e-8)
              rho = prsl(i,1) / (rd*t1(i)*(one+fvirt*tem1))
              if (wind(i) > zero) then
                tem = - rho * stress_wat(i) / wind(i)
                dusfci_cpl(i) = tem * ugrs1(i)   ! U-momentum flux
                dvsfci_cpl(i) = tem * vgrs1(i)   ! V-momentum flux
              else
                dusfci_cpl(i) = zero
                dvsfci_cpl(i) = zero
              endif
              dtsfci_cpl(i) = cp   * rho * hflx_wat(i) ! sensible heat flux over open ocean
              dqsfci_cpl(i) = hvap * rho * evap_wat(i) ! latent heat flux over open ocean
            else                                       ! use results from PBL scheme for 100% open ocean
              dusfci_cpl(i) = dusfc1(i)
              dvsfci_cpl(i) = dvsfc1(i)
              dtsfci_cpl(i) = dtsfc1(i)*hffac(i)
              dqsfci_cpl(i) = dqsfc1(i)*hefac(i)
            endif
!
            dusfc_cpl (i) = dusfc_cpl(i) + dusfci_cpl(i) * dtf
            dvsfc_cpl (i) = dvsfc_cpl(i) + dvsfci_cpl(i) * dtf
            dtsfc_cpl (i) = dtsfc_cpl(i) + dtsfci_cpl(i) * dtf
            dqsfc_cpl (i) = dqsfc_cpl(i) + dqsfci_cpl(i) * dtf
!
          else
            dusfc_cpl(i) = huge
            dvsfc_cpl(i) = huge
            dtsfc_cpl(i) = huge
            dqsfc_cpl(i) = huge
!!
          endif ! Ocean only, NO LAKES
        enddo
      endif

I will make the corresponding change in module_MYNNPBL_wrapper.F90 and push it to the PR.

DomHeinzeller · 2020-06-25T16:02:49Z

Could you modify similar line in GFS_PBL_generic.F90
if (fice(i) > one - epsln) then ! no open water, use results from CICE
epsln is not used and can be removed. Thanks!

This will impact the s2s runs when we merge this to the authoritative repositories. Is this what we want?

Shan, I can't find this line in GFS_PBL_generic.F90. That file in gsd/develop has:

!  --- ...  coupling insertion

      if (cplflx) then
        do i=1,im
          if (oceanfrac(i) > zero) then ! Ocean only, NO LAKES
            if ( .not. wet(i)) then ! no open water
              if (flag_cice(i)) then !use results from CICE
                dusfci_cpl(i) = dusfc_cice(i)
                dvsfci_cpl(i) = dvsfc_cice(i)
                dtsfci_cpl(i) = dtsfc_cice(i)
                dqsfci_cpl(i) = dqsfc_cice(i)
              else !use PBL fluxes when CICE fluxes is unavailable
                dusfci_cpl(i) = dusfc1(i)
                dvsfci_cpl(i) = dvsfc1(i)
                dtsfci_cpl(i) = dtsfc1(i)
                dqsfci_cpl(i) = dqsfc1(i)
              end if
            elseif (icy(i) .or. dry(i)) then ! use stress_ocean from sfc_diff for opw component at mixed point
              tem1 = max(q1(i), 1.e-8)
              rho = prsl(i,1) / (rd*t1(i)*(one+fvirt*tem1))
              if (wind(i) > zero) then
                tem = - rho * stress_wat(i) / wind(i)
                dusfci_cpl(i) = tem * ugrs1(i)   ! U-momentum flux
                dvsfci_cpl(i) = tem * vgrs1(i)   ! V-momentum flux
              else
                dusfci_cpl(i) = zero
                dvsfci_cpl(i) = zero
              endif
              dtsfci_cpl(i) = cp   * rho * hflx_wat(i) ! sensible heat flux over open ocean
              dqsfci_cpl(i) = hvap * rho * evap_wat(i) ! latent heat flux over open ocean
            else                                       ! use results from PBL scheme for 100% open ocean
              dusfci_cpl(i) = dusfc1(i)
              dvsfci_cpl(i) = dvsfc1(i)
              dtsfci_cpl(i) = dtsfc1(i)*hffac(i)
              dqsfci_cpl(i) = dqsfc1(i)*hefac(i)
            endif
!
            dusfc_cpl (i) = dusfc_cpl(i) + dusfci_cpl(i) * dtf
            dvsfc_cpl (i) = dvsfc_cpl(i) + dvsfci_cpl(i) * dtf
            dtsfc_cpl (i) = dtsfc_cpl(i) + dtsfci_cpl(i) * dtf
            dqsfc_cpl (i) = dqsfc_cpl(i) + dqsfci_cpl(i) * dtf
!
          else
            dusfc_cpl(i) = huge
            dvsfc_cpl(i) = huge
            dtsfc_cpl(i) = huge
            dqsfc_cpl(i) = huge
!!
          endif ! Ocean only, NO LAKES
        enddo
      endif

I will make the corresponding change in module_MYNNPBL_wrapper.F90 and push it to the PR.

@shansun6 please check this commit I just pushed: 728c076

Mods to MYNN sfc and PBL for fractional/coupled for latest gsd/develop code (based on #40)

Address Chunxi's comments

Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'

benwgreen and others added 6 commits June 10, 2020 11:21

Merge pull request #1 from NOAA-GSD/gsd/develop

1d8328c

update 6/10/2020

Merge branch 'gsd/develop' of https://github.com/benwgreen/ccpp-physics…

4e9bf5d

… into gsd/develop

Mods to GSL physics for fractional

e889b03

Merge remote-tracking branch 'origin/gsd/develop' into bwg_mod_for_frac

2d5ca0b

Cosmetic changes to MYNNPBL

707dece

cleanup of .meta file order to match corresponding .F90

37719da

benwgreen requested a review from DomHeinzeller as a code owner June 18, 2020 21:40

DomHeinzeller reviewed Jun 18, 2020

View reviewed changes

climbfuji mentioned this pull request Jun 25, 2020

Mods to MYNN sfc and PBL for fractional/coupled for latest gsd/develop code (based on #40) #41

Merged

ShanSunNOAA reviewed Jun 25, 2020

View reviewed changes

Comment thread physics/module_MYNNPBL_wrapper.F90

ShanSunNOAA reviewed Jun 25, 2020

View reviewed changes

DomHeinzeller added a commit that referenced this pull request Jun 25, 2020

Merge pull request #41 from climbfuji/ben_bwg_mod_for_frac

022ae37

Mods to MYNN sfc and PBL for fractional/coupled for latest gsd/develop code (based on #40)

DomHeinzeller merged commit 0d6db42 into NOAA-GSL:gsd/develop Jun 25, 2020

benwgreen deleted the bwg_mod_for_frac branch February 25, 2021 16:41

benwgreen restored the bwg_mod_for_frac branch February 25, 2021 16:41

benwgreen deleted the bwg_mod_for_frac branch June 8, 2021 20:27

zhanglikate referenced this pull request in zhanglikate/ccpp-physics Feb 10, 2023

Merge pull request NCAR#40 from barlage/NoahMP_p8c_mynn

acd2058

Address Chunxi's comments

zhanglikate referenced this pull request in zhanglikate/ccpp-physics Mar 1, 2024

Merge pull request NCAR#40 from mdtoyNOAA/ufs/dev_drag_suite_intent_mods

235ef96

Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'

zhanglikate referenced this pull request in zhanglikate/ccpp-physics Mar 1, 2024

Merge pull request NCAR#40 from mdtoyNOAA/ufs/dev_drag_suite_intent_mods

e167925

Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mods to MYNN sfc and PBL for fractional/coupled#40

Mods to MYNN sfc and PBL for fractional/coupled#40
DomHeinzeller merged 6 commits into
NOAA-GSL:gsd/developfrom
benwgreen:bwg_mod_for_frac

benwgreen commented Jun 18, 2020

Uh oh!

DomHeinzeller left a comment

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

Uh oh!

ShanSunNOAA left a comment

Uh oh!

climbfuji commented Jun 25, 2020

Uh oh!

ShanSunNOAA commented Jun 25, 2020 via email

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

benwgreen commented Jun 18, 2020

Uh oh!

DomHeinzeller left a comment

Choose a reason for hiding this comment

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

Uh oh!

ShanSunNOAA left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Jun 25, 2020

Uh oh!

ShanSunNOAA commented Jun 25, 2020 via email

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

DomHeinzeller commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants