Bug fix for snow initialization in GFS_surface_composites.F90#131
Closed
tanyasmirnova wants to merge 1 commit into
Closed
Bug fix for snow initialization in GFS_surface_composites.F90#131tanyasmirnova wants to merge 1 commit into
tanyasmirnova wants to merge 1 commit into
Conversation
tanyasmirnova
commented
Mar 9, 2022
tanyasmirnova
commented
- Bug fix for snow initialization in GFS_surface_composites.F90
- Set compute_fluxes=.true. in module_sf_mynn.F90
2. Set compute_fluxes=.true. in module_sf_mynn.F90
tanyasmirnova
requested review from
DomHeinzeller and
SamuelTrahanNOAA
as code owners
Collaborator
|
You need to merge @mdtoyNOAA's changes into your branch, and create PRs at the fv3atm and ufs-weather-model level. |
Collaborator
|
I thought I had already done this, i.e.:
NOAA-GSL/fv3atm — PR #129
NOAA-GSL/ufs-weather-model — PR #122
… On Mar 10, 2022, at 9:41 AM, Samuel Trahan (NOAA contractor) ***@***.***> wrote:
You need to merge @mdtoyNOAA <https://github.com/mdtoyNOAA>'s changes into your branch, and create PRs at the fv3atm and ufs-weather-model level.
—
Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRVLIA73LQTGOFY63YCSSTU7IQ4ZANCNFSM5QK7ZVXQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
Collaborator
|
@mdtoyNOAA Those issues are closed. Tanya's current branch has to be up-to-date with the top of RRFS_dev. |
Collaborator
|
This PR's branch must be updated to the top of RRFS_dev now that #137 has been merged. We also need PRs at the fv3atm and ufs-weather-model level. |
joeolson42
approved these changes
Mar 15, 2022
| LOGICAL, PARAMETER :: compute_diag = .false. | ||
| LOGICAL, PARAMETER :: compute_flux = .false. !shouldn't need compute | ||
| LOGICAL, PARAMETER :: compute_flux = .true. !shouldn't need compute | ||
| ! these in FV3. They will be written over anyway. |
Collaborator
There was a problem hiding this comment.
I think this is OK for now. In the near future, this flag will have to made into a namelist option.
Collaborator
|
Does #138 replace this? If so, please close this PR. |
Collaborator
|
I need pull requests in fv3atm and ufs-weather-model before I can test or merge this. |
zhanglikate
referenced
this pull request
in zhanglikate/ccpp-physics
Mar 1, 2024
fix grv function for argument value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.