Skip to content

Updating SGS cloud interstitial to add Chab-Becht cloud fraction and … #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamuelTrahanNOAA merged 4 commits into from
Feb 24, 2022
Merged

Updating SGS cloud interstitial to add Chab-Becht cloud fraction and … #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0278c10
Updating SGS cloud interstitial to add Chab-Becht cloud fraction and …
joeolson42 Feb 16, 2022
e76bc19
moving ud_mf to TBD block in GFS_debug.F90
joeolson42 Feb 17, 2022
c550ef8
updated comments in SGSCloud_RadPre and Post
joeolson42 Feb 22, 2022
179682e
Merge branch 'sgsradpre' of https://github.com/joeolson42/ccpp-physic…
joeolson42 Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion physics/GFS_debug.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,9 @@ subroutine GFS_diagtoscreen_run (Model, Statein, Stateout, Sfcprop, Coupling,
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%acvb' , Tbd%acvb)
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%acvt' , Tbd%acvt)
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%hpbl' , Tbd%hpbl)
if (Model%imfdeepcnv .ge. 0 .or. Model%imfshalcnv .ge. 0) then
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%ud_mf' , Tbd%ud_mf)
end if
if (Model%do_sppt) then
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%dtdtnp' , Tbd%dtdtnp)
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Tbd%dtotprcp' , Tbd%dtotprcp)
Expand Down Expand Up @@ -1331,7 +1334,6 @@ subroutine GFS_interstitialtoscreen_run (Model, Statein, Stateout, Sfcprop, Coup
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_ice ', Interstitial%tsurf_ice )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_land ', Interstitial%tsurf_land )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_water ', Interstitial%tsurf_water )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%ud_mf ', Interstitial%ud_mf )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%uustar_ice ', Interstitial%uustar_ice )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%uustar_land ', Interstitial%uustar_land )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%uustar_water ', Interstitial%uustar_water )
Expand Down
9 changes: 5 additions & 4 deletions physics/module_SGSCloud_RadPost.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ end subroutine sgscloud_radpost_finalize
subroutine sgscloud_radpost_run( &
im,levs, &
flag_init,flag_restart, &
qc,qi, &
qc_save,qi_save, &
qc,qi,qs, &
qc_save,qi_save,qs_save, &
errmsg,errflg )

! should be moved to inside the mynn:
Expand All @@ -34,8 +34,8 @@ subroutine sgscloud_radpost_run( &

integer, intent(in) :: im, levs
logical, intent(in) :: flag_init, flag_restart
real(kind=kind_phys), dimension(:,:), intent(inout) :: qc, qi
real(kind=kind_phys), dimension(:,:), intent(in) :: qc_save, qi_save
real(kind=kind_phys), dimension(:,:), intent(inout) :: qc, qi, qs
real(kind=kind_phys), dimension(:,:), intent(in) :: qc_save, qi_save, qs_save
character(len=*), intent(out) :: errmsg
integer, intent(out) :: errflg
! Local variable
Expand All @@ -58,6 +58,7 @@ subroutine sgscloud_radpost_run( &
do i = 1, im
qc(i,k) = qc_save(i,k)
qi(i,k) = qi_save(i,k)
qs(i,k) = qs_save(i,k)
enddo
enddo

Expand Down
16 changes: 16 additions & 0 deletions physics/module_SGSCloud_RadPost.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@
type = real
kind = kind_phys
intent = inout
[qs]
standard_name = snow_mixing_ratio
long_name = ratio of mass of snow water to mass of dry air plus vapor (without condensates)
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
intent = inout
[qc_save]
standard_name = cloud_condensed_water_mixing_ratio_save
long_name = ratio of mass of cloud water to mass of dry air plus vapor (without condensates) before entering a physics scheme
Expand All @@ -67,6 +75,14 @@
type = real
kind = kind_phys
intent = in
[qs_save]
standard_name = snow_mixing_ratio_save
long_name = cloud snow mixing ratio before entering a physics scheme
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
intent = in
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down
Loading