Adding check for existence of FFG file to avoid crash when missing, and handling of interpolation to rotated lat-lon grid.#12
Merged
Conversation
hu5970
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A check for the existence of FFG file is added to SURFCE.f to ensure UPP will not crash when these files are missing (i.e., on every system but Jet). Some unneeded variables were also removed from the code.
I also added to grib2_module.f to allow interpolation of FFG data to 3km NA RRFS domain (rotated lat-lon grid).
Updated code was tested for 3km NA RRFS on Jet and 13km NA RRFS on Orion.