ci: make "create cache" a reusable workflow#69
Merged
fmalatino merged 6 commits intoOct 27, 2025
Merged
Conversation
8 tasks
7 tasks
Collaborator
Author
|
/cc @twicki for some reason I can't tag you as a reviewer |
fmalatino
approved these changes
Oct 24, 2025
Contributor
I just added him as a contributor. Going forward he should be accessible. |
Collaborator
Author
Thanks, Frank! |
jjuyeonkim
approved these changes
Oct 24, 2025
Collaborator
Author
|
With everybody's approval, can we get this one merged? The merging order for these PRs is
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent (planned) downtime of NCCS portal showed a whole in our translate test data caching strategy. When we run pySHiELD tests as re-usable workflow in e.g. NDSL tests, we don't cache the translate test data. To do so, we can "upgrade" the "create cache" workflow to be re-usable such that we can call it from e.g. NDSL when we create the cache there.
GHA doesn't provide a way to detect
workflow_callas an event (e.g.github.eventwill beworkflow_dispatchin that case, which is the same as for a manual dispatch). We thus create an artificial input in case the workflow is called from another workflow. That way we know. The artificial input has a default value such that we don't need to set it from the calling workflow.How Has This Been Tested?
Tested on my fork, e.g. romanc/NDSL#5.
Checklist: