Skip to content

Type tweaks: WrappedHaloUpdater + explicit parameter passing#96

Merged
jjuyeonkim merged 2 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251028_type_adj
Oct 29, 2025
Merged

Type tweaks: WrappedHaloUpdater + explicit parameter passing#96
jjuyeonkim merged 2 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251028_type_adj

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

@jjuyeonkim jjuyeonkim commented Oct 28, 2025

Description

Small proposed type adjustments:

  • Using WrappedHaloUpdater
  • Using explicit parameter passing instead of 'kwargs'

Without these modifications, there are type linting errors when attempting to update the submodules for Pace: NOAA-GFDL/pace#156

How Has This Been Tested?
CI passes, linting passes in Pace locally with this update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@jjuyeonkim jjuyeonkim marked this pull request as ready for review October 28, 2025 17:04
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's a bit weird that only pace's mypy is complaining and pyfv3's mypy is fine. Let's worry about that in a follow-up PR.

@romanc romanc mentioned this pull request Oct 29, 2025
8 tasks
@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 29, 2025
Merged via the queue into NOAA-GFDL:develop with commit bca2210 Oct 29, 2025
4 checks passed
@jjuyeonkim jjuyeonkim deleted the 20251028_type_adj branch December 23, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants