Skip to content

refactor: avoid deprecation warnings around extra dims#94

Merged
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/avoid-warnings-extra-dims
Oct 28, 2025
Merged

refactor: avoid deprecation warnings around extra dims#94
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/avoid-warnings-extra-dims

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Oct 28, 2025

Description

"extra dims" have been renamed to "data dimensions" in NDSL 1 and after doing so we figured that we need to be careful with mutable default values 2. Togehter, these two PRs make specifying extra_dim_lengths unnecessary if they are the default empty dictionary.

How Has This Been Tested?

All good as long as CI is happy.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

"extra dims" have been renamed to "data dimensions" in NDSL [1] and
after doing so we figured that we need to be careful with mutable
default values [2]. Togehter, these two PRs make specifying
`extra_dim_lengths` unnecessary if they are the default empty
dictionary.

[1]: NOAA-GFDL/NDSL#272
[2]: NOAA-GFDL/NDSL#277
Copy link
Copy Markdown
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge if we want it in before the release

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NOAA-GFDL:develop with commit e4a04eb Oct 28, 2025
4 checks passed
@romanc romanc deleted the romanc/avoid-warnings-extra-dims branch October 28, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants