refactor: avoid deprecation warnings around extra dims#94
Merged
FlorianDeconinck merged 2 commits intoOct 28, 2025
Merged
Conversation
"extra dims" have been renamed to "data dimensions" in NDSL [1] and after doing so we figured that we need to be careful with mutable default values [2]. Togehter, these two PRs make specifying `extra_dim_lengths` unnecessary if they are the default empty dictionary. [1]: NOAA-GFDL/NDSL#272 [2]: NOAA-GFDL/NDSL#277
twicki
approved these changes
Oct 28, 2025
Collaborator
twicki
left a comment
There was a problem hiding this comment.
Looks ready to merge if we want it in before the release
FlorianDeconinck
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"extra dims" have been renamed to "data dimensions" in NDSL 1 and after doing so we figured that we need to be careful with mutable default values 2. Togehter, these two PRs make specifying
extra_dim_lengthsunnecessary if they are the default empty dictionary.How Has This Been Tested?
All good as long as CI is happy.
Checklist: