Skip to content

ci: per repo concurrency group#93

Merged
fmalatino merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/per-repo-concurrency-group
Oct 30, 2025
Merged

ci: per repo concurrency group#93
fmalatino merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/per-repo-concurrency-group

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Oct 28, 2025

Description

Quick follow-up from #91: specialize concurrency group per repository. Otherwise, we'll have deadlocks for concurrency groups and the cache won't be built:

image

Link to the above workflow.

Note: using ${{ github.repository }} sounds like a good idea. In practice, that doesn't play nice when the workflow is called from another repository because in that case, github.repository resolves to the calling repository.

Related: NOAA-GFDL/pySHiELD#70.

How Has This Been Tested?

By staring at the code. I'll verify post-merge that this works as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Note: using `${{ github.repository }}` sounds like a good idea. In
practice, that doesn't play nice when the workflow is called from
another repository because in that case, `github.repository` resolves
to the calling repository.
@fmalatino fmalatino added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NOAA-GFDL:develop with commit a343c41 Oct 30, 2025
4 checks passed
@romanc romanc deleted the romanc/per-repo-concurrency-group branch October 30, 2025 15:10
@romanc romanc mentioned this pull request Oct 30, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants