Skip to content

Use new corners in del2cubed stencil#92

Merged
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/update-copy-corners
Oct 28, 2025
Merged

Use new corners in del2cubed stencil#92
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/update-copy-corners

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Oct 27, 2025

Description

Follow-up from PR #87, let's use the new corner implementation in del2cubed. The stencil is used in the translate tests and currently emits a deprecation warning.

How Has This Been Tested?

The stencil is called as part of the translate tests. All good as long as they still pass.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Follow-up from PR NOAA-GFDL#87, let's use the new corner implementation.
@romanc romanc changed the title Use new corners in del2cubed stencil Use new corners in del2cubed stencil Oct 27, 2025
Comment thread pyfv3/stencils/del2cubed.py
Copy link
Copy Markdown
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NOAA-GFDL:develop with commit 4945b11 Oct 28, 2025
4 checks passed
@romanc romanc deleted the romanc/update-copy-corners branch October 28, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants