Skip to content

Type fix: tuple to list in DynamicalCoreConfig #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjuyeonkim merged 1 commit into from
Oct 24, 2025
Merged

Type fix: tuple to list in DynamicalCoreConfig #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyfv3/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,8 @@ def from_f90nml(
use when initializing the DynamicalCoreConfig. If None, all
groups will be used. (Default: DEFAULT_DYCORE_NML_GROUPS)
"""
nml_dict = f90nml_as_dict(nml, flatten=True, target_groups=target_groups)
groups = list(target_groups) if target_groups is not None else None
nml_dict = f90nml_as_dict(nml, flatten=True, target_groups=groups)
nml_dict["target_nml_groups"] = target_groups
return cls.from_dict(nml_dict)

Expand Down