NDSL Issue#64: Use from_yaml_dict instead of from_f90nml in GEOS wrapper#86
Closed
jjuyeonkim wants to merge 2 commits into
Closed
NDSL Issue#64: Use from_yaml_dict instead of from_f90nml in GEOS wrapper#86jjuyeonkim wants to merge 2 commits into
jjuyeonkim wants to merge 2 commits into
Conversation
fmalatino
approved these changes
Sep 19, 2025
Collaborator
Author
|
We had a meeting, and I'm not sure if this is still relevant. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part of the Namelist Refactor work, though a bit indirectly related.
Changes include the following:
DynamicalCoreConfig.from_yamlfunctionality into a newfrom_yaml_dictfunction.from_yaml_dictfunction in the GEOS wrapper instead of usingfrom_f90nml.Why use
from_yaml_dict?The GEOS wrapper is the one case I found where the YAML structure is used to create a
f90nml.Namelist, so I wanted to instead use thefrom_yamlcode to process it instead of thefrom_f90nml.The GEOS wrapper is tested in an existing Pace unit test (
tests/main/fv3core/test_init_from_geos.py). The test uses anamelist_dictthat follows the YAML configuration structure. Thisnamelist_dictis then turned into af90nml.Namelistand used to initialize a dycore config object.If I can keep YAML and Namelist processing more distinct, I think this will help make the Namelist refactoring simpler. I can then expect all of the
Namelistobjects to use a typical Fortran Namelist group structure. I plan to eventually change thendsl.Namelistto behave much more like thef90nml.Namelistand not have to worry about being able to handle Namelists with either YAML structure orinput.nmlstructure.Fixes: NOAA-GFDL/NDSL#64 (partially)
How Has This Been Tested?
PyFV3 and PySHiELD translate tests run as expected compared to the
developbranch. Pace unit tests also pass as expected.Checklist: