Skip to content

ci: expose python version for translate tests#118

Merged
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gha-translate-test-python-version
Feb 5, 2026
Merged

ci: expose python version for translate tests#118
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gha-translate-test-python-version

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Feb 5, 2026

Description

With NDSL supporting more than one version of python, we'd like to have the possibility to run pyFV3 translate tests with different versions of python. This PR adds an optional input variable to the workflow_call which allows calling workflows to specify the python version.

The PR also removes usage of the component_trigger input variable. The input is redundant with component_name, which is a non-empty string whenever component_trigger is true. I keep the input around until we update all calling workflows to not set it anymore.

How Has This Been Tested?

By running the current CI. The workflow_call was tested with NOAA-GFDL/NDSL#376 requesting to run PyFV3 tests with python 3.12 and with the default python version.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

@romanc romanc force-pushed the romanc/gha-translate-test-python-version branch 3 times, most recently from f23470c to c665c8d Compare February 5, 2026 09:28
@romanc romanc marked this pull request as draft February 5, 2026 09:37
@romanc romanc force-pushed the romanc/gha-translate-test-python-version branch from 1ad54d3 to 377c848 Compare February 5, 2026 09:51
With NDSL supporting more than one version of python, we'd like to have
the possibility to run pyFV3 translate tests with different versions of
python. This PR adds an optional input variable to the `workflow_call`
which allows calling workflows to specify the python version.

The PR also removes usage of the `component_trigger` input variable. The
input is redundant with `component_name`, which is a non-empty string
whenever `component_trigger` is true. I keep the input around until we
update all calling workflows to not set it anymore.
@jjuyeonkim jjuyeonkim added this pull request to the merge queue Feb 5, 2026
Merged via the queue into NOAA-GFDL:develop with commit 091bc1c Feb 5, 2026
5 checks passed
@romanc romanc deleted the romanc/gha-translate-test-python-version branch February 5, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants