Skip to content

PyFV3: Removing --no_legacy_namelist flag#100

Merged
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
jjuyeonkim:20251113_no_legacy_namelist_cleanup
Nov 14, 2025
Merged

PyFV3: Removing --no_legacy_namelist flag#100
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
jjuyeonkim:20251113_no_legacy_namelist_cleanup

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

Description
This is a follow-up (clean-up) from PR NOAA-GFDL/NDSL#297.

It removes the flag --no_legacy_namelist flag from the github workflows.

How Has This Been Tested?
It passes CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@jjuyeonkim jjuyeonkim marked this pull request as ready for review November 13, 2025 22:17
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@jjuyeonkim
Copy link
Copy Markdown
Collaborator Author

There seems to be an intermittent CI failure with the pyFV3 translate tests. It failed the first time in the merge queue, but passed when I reran. I'm noting this here. I'm going to try to merge one more time.

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Nov 14, 2025
@romanc
Copy link
Copy Markdown
Collaborator

romanc commented Nov 14, 2025

There seems to be an intermittent CI failure with the pyFV3 translate tests. It failed the first time in the merge queue, but passed when I reran. I'm noting this here. I'm going to try to merge one more time.

Yeah, we have seen this before. It usually goes away when re-runnig...

Merged via the queue into NOAA-GFDL:develop with commit cfc664b Nov 14, 2025
5 checks passed
@jjuyeonkim jjuyeonkim deleted the 20251113_no_legacy_namelist_cleanup branch November 14, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants