-
Notifications
You must be signed in to change notification settings - Fork 5
Changing build backend to scikit-build-core
#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9cdeffc
Pre-lim install changes
fmalatino 4e80357
Merge branch 'main' into fix/build_system
fmalatino a40dc30
Testing conda install of cFMS locally
fmalatino c28e606
Switching to main
fmalatino 6090002
Merging main
fmalatino 055f01a
Merge branch 'main' into fix/build_system
fmalatino fdd3d25
Branch for installing cFMS from conda package
fmalatino 4da5be8
Adding override for editable_wheel for setuptools for editable installs
fmalatino a3ba236
Current status of build system
fmalatino 691d3be
Pre-lim work to use cmake install of cfms
fmalatino 711f80d
Checking use as a dependency
fmalatino 23f7628
Pre-lim workflow file for new install
fmalatino f2d3aab
Installing Python in cmake workflow
fmalatino d393bb8
Adding installation of lsb-release to cmake workflow
fmalatino ff9df29
Trying sudo in cmake workflow for install of lsb-release
fmalatino d5180e0
Bumping Python required version to >=3.12
fmalatino 35f2453
Merge main
fmalatino 47be94a
Amending workflows for new Python
fmalatino b9d6845
Updating before dependency install in unit test workflow
fmalatino 2dd8023
Making install verbose in workflow
fmalatino 7e0d56a
Linting and fixing of test_define_domains
fmalatino a51efb6
Amending interface fro declare_pelist
fmalatino 92ebaeb
Amending lint workflow
fmalatino 2e35b98
Amending test_gather use of get_current_pelist
fmalatino b8c57b8
Using dev build option when linting
fmalatino 0d861ab
Amending horiz_interp test use of get_current_pelist
fmalatino d0b3096
Amending all tests for use of get_current_pelist
fmalatino 4ce868a
Using xarray open_dataset in test_diag_manager
fmalatino 05086e0
Fixing linting issues
fmalatino 82c947e
Pointing to branch of cFMS for CMake build
fmalatino 02085a3
Using correct URL for cFMS
fmalatino 578ddf9
Added installation instructions to README
fmalatino 5a279b5
Linting
fmalatino 08a1164
Updating action steps names in Lint workflow
fmalatino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +0,0 @@ | ||
|
|
||
| [submodule "cFMS"] | ||
| path = cFMS | ||
| url = https://github.com/NOAA-GFDL/cFMS.git | ||
| branch = main | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| cmake_minimum_required(VERSION 3.18) | ||
|
|
||
| project(pyfms LANGUAGES C Fortran) | ||
|
|
||
| include(FetchContent) | ||
|
|
||
| set(CMAKE_POSITION_INDEPENDENT_CODE ON) | ||
|
|
||
| FetchContent_Declare( | ||
| cFMS | ||
| GIT_REPOSITORY https://github.com/fmalatino/cFMS.git | ||
| GIT_TAG cmake | ||
| ) | ||
| FetchContent_MakeAvailable(cFMS) | ||
|
|
||
| install(TARGETS cFMS DESTINATION ${SKBUILD_PLATLIB_DIR}) | ||
Submodule cFMS
deleted from
ea7636
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.