Refactor: NDSL#58
Merged
Merged
Conversation
* Move `pace.dsl` to local `ndsl.dsl` * Replacing gt4py_utils.halo by pace.util.N_HALO_DEFAULT * Move .gitmodules out of main pace Tmp reqs file for NDSL Updated dependencies for other packages * pace.stencils -> ndsl.stencils * Moved Dycore<>Physics bridge out of `ndsl` Move out translate test back to Physics * Fix driver reference to update_atmos_state * Remove pace.stencils * pace.util -> ndsl.util * Move util test & examples * Delete pace.util * Rely on ndsl submodule * Lint (for import order) * Remove unused import, fix missing import * Restore gitmodule strategy * Update requitements of model packages * Moved translate_driver into Pace/tests Fix physics local import * Lint (couple of type ignore on bad ENUM read) * Push c12_restart * Bad restart path * Bad path
…/pace/driver/performance -> ndsl/performance
FlorianDeconinck
approved these changes
Feb 2, 2024
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
Collaborator
There was a problem hiding this comment.
This is by construct an un-reviewable PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The middleware layer of Pace has been moved to a submodule NDSL
Code changes:
Requirements changes:
Infrastructure changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated