refactor: prefer backend over gt4py_backend#170
Merged
Conversation
On `Quantities`, we currently allow both `backend` and `gt4py_backend` where the later is deprecated and about to be removed. See NOAA-GFDL/NDSL#312 and NOAA-GFDL/NDSL#314 for context.
romanc
commented
Jan 6, 2026
Comment on lines
-289
to
-293
| backend = quantity_factory.zeros( | ||
| dims=[X_DIM, Y_DIM], units="unknown" | ||
| ).gt4py_backend | ||
|
|
||
| dycore_state = self._initialize_dycore_state(communicator, backend) |
Collaborator
Author
There was a problem hiding this comment.
Since the refactor in NDSL, the backend is now known and saved on the QuantityFactory. No need to allocate something just to get the name of the backend.
fmalatino
approved these changes
Jan 6, 2026
Collaborator
Author
|
@oelbert I'd like to move on this PR. It is blocking NOAA-GFDL/NDSL#357, which we scheduled for the next NDSL release. A similar PR in PyFV3 was approved and is ready to merge. Is there anything I can do from my side to get traction on this simple refactor? |
oelbert
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On
Quantities, we currently allow bothbackendandgt4py_backendwhere the later is deprecated and about to be removed.See NOAA-GFDL/NDSL#312 and NOAA-GFDL/NDSL#314 for context.
/cc @FlorianDeconinck
How Has This Been Tested?
Search and manual replace of
gt4py_backendwithbackendwithin pace. CI is still green.Checklist: