refactor: use new constructor of QuantityFactory#169
Merged
Conversation
Prefer the new constructor of `QuantityFactor` over the deprecated call to `QuantityFactor.from_backend(...)`. This removes a bunch of deprecation warnings in tests.
Collaborator
Author
|
Related PRs in pyFV3 and pySHiELD are |
fmalatino
approved these changes
Jan 6, 2026
7 tasks
Collaborator
Author
|
@oelbert I'd like to move on this PR. It is blocking NOAA-GFDL/NDSL#356, which we scheduled for the next NDSL release. A similar PR in PyFV3 was approved and is ready to merge. Is there anything I can do from my side to get traction on this simple refactor? |
oelbert
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prefer the new constructor of
QuantityFactorover the deprecated call toQuantityFactor.from_backend(...). This removes a bunch of deprecation warnings in tests.See NOAA-GFDL/NDSL#228 for context.
/cc @FlorianDeconinck
How Has This Been Tested?
Search and manual replace of
from_backendwithin pace. CI is still green. The remaining deprecation warnings in tests come from pyFV3 and pySHiELD. PRs in these repos are coming up shortly. Once they are merge, we can update the submodules and the CI output should be significantly shorter again 😉Checklist: