refactor: avoid deprecation warnings after update#157
Merged
jjuyeonkim merged 2 commits intoOct 30, 2025
Conversation
Change `extra_dim_lengths` -> `data_dimensions` when creating a
`SubtileGridSizer`. We can remove empty dictionaries `{}` because that's
now the default. Previously that default wasn't re-entrant so many
places specified the option explicitly. Now there's no need anymore for
this.
Collaborator
Author
|
/cc @twicki & @FlorianDeconinck FYI |
9 tasks
5ea9cee to
f752b50
Compare
fmalatino
approved these changes
Oct 30, 2025
jjuyeonkim
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up from updating NDSL in PR #156. We get rid of deprecation warnings to avoid future problems when the API changes.
Quick note on the
extra_dim_lengths: We can remove empty dictionaries{}because that's now the default. Previously that default wasn't re-entrant so many places specified the option explicitly. Now there's no need anymore for this.How Has This Been Tested?
This is a pure refactor. All good as long as current tests don't complain.
Checklist: