just to test: Don't upgrade pip, setuptools, wheels#116
Closed
romanc wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Wat #python |
Collaborator
Author
|
To be fair: pip is printing warnings for that ever since (and probably
before) I joined the project. It's just never a good combination to have
auto-upgrading in a production CI workflow
…On Tue, Apr 29, 2025, 17:59 Florian Deconinck ***@***.***> wrote:
*FlorianDeconinck* left a comment (NOAA-GFDL/pace#116)
<#116 (comment)>
Wat #python
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIQUSQBEYQWJV72RKJQVRL236OX5AVCNFSM6AAAAAB4DL4RICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZZGQZTQMJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
Yeah... We just going to have to redo a bunch of workflow and go to pyproject after all. Sigh. |
Collaborator
Author
|
Yeah we don't need to move immediately. For now we are anyway on python
3.11, which is still 'safe' with that regard. Once we lift that
restriction, we have to take another look at dev installs / local setups.
The other question here is why this workflow is configured to do an
editable install of PyFV3. That seems not necessary to me. We should
probably also look at using a virtual environment because pip is - even
with this patch - complaining about dependency conflicts (with system
installs) as far as I could see. There's much to clean up before we have to
move to a pyproject (where we - as you said - eventually have to go to)....
…On Tue, Apr 29, 2025, 18:43 Florian Deconinck ***@***.***> wrote:
*FlorianDeconinck* left a comment (NOAA-GFDL/pace#116)
<#116 (comment)>
Yeah... We just going to have to redo a bunch of workflow and go to
pyproject after all. Sigh.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIQUSUV6VNAMTHB7OVAMIL236T4JAVCNFSM6AAAAAB4DL4RICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZZGU2TSNZSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Author
|
closing in favor of PR #117 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
If this is a hotfix to a released version, please specify it.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist: