Skip to content

fixed CubedSphereCommunicator call to use mpi_comm_dsl correctly#115

Merged
fmalatino merged 3 commits into
NOAA-GFDL:developfrom
lharris4:develop
Sep 12, 2025
Merged

fixed CubedSphereCommunicator call to use mpi_comm_dsl correctly#115
fmalatino merged 3 commits into
NOAA-GFDL:developfrom
lharris4:develop

Conversation

@lharris4
Copy link
Copy Markdown
Contributor

Description
Minor fix to one of the example notebooks. Thanks to @oelbert for helping me fix this.

How Has This Been Tested?

Notebook now runs to completion and completes its task.

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@lharris4
Copy link
Copy Markdown
Contributor Author

lharris4 commented May 1, 2025

Hi, all. I don't understand why the unit test failed. Is this due to an error in baroclinic_example.ipynb? Or is it some other script? I was able to get the notebook to run OK when testing in the container on an M1 MacBook Pro.

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Not your fault here, some pip related details are tripping the CI. @fmalatino and @romanc are on it, we will clean up PRs when things stabilizes

@romanc
Copy link
Copy Markdown
Collaborator

romanc commented May 1, 2025

Frank merged #117 yesterday. Have you tried updating/rebasing your branch after that?

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Frank merged #117 yesterday. Have you tried updating/rebasing your branch after that?

Something is off with Github CI, it's not the latest that's being pulled. Will solve offline.

@fmalatino
Copy link
Copy Markdown
Contributor

Frank merged #117 yesterday. Have you tried updating/rebasing your branch after that?

Something is off with Github CI, it's not the latest that's being pulled. Will solve offline.

The branch being tested is still behind 117 by one commit, updating it should resolve the issue.

Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you merge the latest version of NOAA-GFDL:develop into this branch it will be all set to merge

@fmalatino fmalatino added this pull request to the merge queue Sep 12, 2025
Merged via the queue into NOAA-GFDL:develop with commit 246e16b Sep 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants