Bugfix for truncation file handle#227
Merged
Hallberg-NOAA merged 1 commit intoDec 3, 2025
Merged
Conversation
This patch fixes a bug that velocity trunction files were not written using FMS2. The issue was that negative file handles returned by open(newunit) is disregarded. This is the same patch as in NOAA-GFDL/MOM6#739 but for SIS2.
Hallberg-NOAA
approved these changes
Dec 3, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes look correct to me.
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/SIS2/-/pipelines/29410. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug that velocity trunction files were not written using FMS2. The issue was that negative file handles returned by open(newunit) is disregarded.
This is the same patch as in NOAA-GFDL/MOM6#739 but for SIS2.