Skip to content

fix: cleanups in translate test discovery#405

Merged
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/translate-test-discovery
Mar 25, 2026
Merged

fix: cleanups in translate test discovery#405
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
romanc:romanc/translate-test-discovery

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Mar 23, 2026

Description

Some refactors/cleanups in the code that discovers translate tests. Follow-up from PR #403 where I messed up the nice error message that we throw in case the translate test is not found.

How has this been tested?

All good as long as CI is still green: we use the translate test discovery system extensively in the CI.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc romanc changed the title cleanups in translate test discovery fixup: cleanups in translate test discovery Mar 23, 2026
@romanc romanc changed the title fixup: cleanups in translate test discovery fix: cleanups in translate test discovery Mar 23, 2026
@romanc romanc marked this pull request as ready for review March 23, 2026 16:09
@romanc romanc requested a review from FlorianDeconinck March 23, 2026 16:09
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Mar 25, 2026
Merged via the queue into NOAA-GFDL:develop with commit b6e94f1 Mar 25, 2026
7 of 8 checks passed
@romanc romanc deleted the romanc/translate-test-discovery branch March 25, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants