Improved data_loader#402
Merged
FlorianDeconinck merged 3 commits intoMar 25, 2026
Merged
Conversation
FlorianDeconinck
requested changes
Mar 18, 2026
romanc
reviewed
Mar 20, 2026
Collaborator
romanc
left a comment
romanc
left a comment
There was a problem hiding this comment.
I'm not sure I understand the use-cases: can you add a use-case that load the wrong data without this change?
Do you know if there any current usage of the isel parameter of load, e.g.load(name, prefix="...", isel=5)? I'm asking because I think this case won't be possible anymore with the currently proposed changes.
Ps, linting seems to be failing ...
FlorianDeconinck
approved these changes
Mar 23, 2026
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
👍 Fix lint and merge in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny PR adding ability for data_loader to auto-detect current savepoint index in the netcdf. Needed for some newer translate tests where the existing translate test systems fail to load 4D variables. No changes to existing code, previous uses of data_loader should be unaffected.