Improved translate test logging#398
Conversation
…tion, and updated the log within the comparision calculations of the translate test
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Looking good - maybe try a few different messages to shorten it? This is an expert system, we don't necessarily needs to be as verbose as I made it in the past
|
Another thought: if "changed" grid points == "all", maybe print only of? |
|
I think there is value to printing both changing points and all points, even when they are the same. It hardly adds any clutter (in fact, I would argue keeping the print the same for all cases makes it easier to read) and it makes it easy to recognize that all points actually change. particularly useful since - when there is no input data to compute changing points, I only print failures of all grid points. I want to keep those two prints fairly distinct so they can be distinguished |
…ing one line result
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Lint + small comment to verobose intent then you can merge
2 participants
Fixed a bug that was incorrectly computing the number of changing points (points that differed between the reference in and out files).
Added a few lines that compute the number of changing columns and failing columns.
Updated the translate test print to show report these new values, and ensure that all are shown on the by the pytest short summary.